-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics-server): add metrics-server component with configuration #2589
base: main
Are you sure you want to change the base?
feat(metrics-server): add metrics-server component with configuration #2589
Conversation
Signed-off-by: Akash <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for getting started with it, I haven't reviewed full.
Have you tried to generate the assets file from jsonnet code added and tried deploying if its working correctly?
@@ -9,5 +9,6 @@ | |||
"prometheusOperator": "0.79.2", | |||
"kubeRbacProxy": "0.18.2", | |||
"configmapReload": "0.14.0", | |||
"pyrra": "0.6.4" | |||
"pyrra": "0.6.4", | |||
"metricsServer": "0.6.4" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use latest release
"metricsServer": "0.6.4" | |
"metricsServer": "0.7.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been resolved!
versionPriority: 100, | ||
}, | ||
}, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: add a new line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this has been resolved!
…ed new line Signed-off-by: Sky Singh <[email protected]>
bd384bf
to
9d5d629
Compare
@slashpai The asset files are being generated successfully! ![]() |
Signed-off-by: Sky Singh <[email protected]>
@slashpai We are ready for review! ![]() |
Description
Add support for installing and configuring metrics-server as an alternative to prometheus-adapter for serving the resource metrics API. This provides:
Type of change
FEATURE
(non-breaking change which adds functionality)Changelog entry