Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics-server): add metrics-server component with configuration #2589

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

SkySingh04
Copy link

Description

Add support for installing and configuring metrics-server as an alternative to prometheus-adapter for serving the resource metrics API. This provides:

  • Configurable metrics-server deployment
  • Integration with kube-prometheus management
  • Latest metrics-server version support
  • Proper RBAC and security settings

Type of change

  • FEATURE (non-breaking change which adds functionality)

Changelog entry

Add support for deploying and configuring metrics-server as an alternative metrics API implementation

@SkySingh04 SkySingh04 requested a review from a team as a code owner January 18, 2025 18:15
Copy link
Contributor

@slashpai slashpai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting started with it, I haven't reviewed full.

Have you tried to generate the assets file from jsonnet code added and tried deploying if its working correctly?

@@ -9,5 +9,6 @@
"prometheusOperator": "0.79.2",
"kubeRbacProxy": "0.18.2",
"configmapReload": "0.14.0",
"pyrra": "0.6.4"
"pyrra": "0.6.4",
"metricsServer": "0.6.4"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use latest release

Suggested change
"metricsServer": "0.6.4"
"metricsServer": "0.7.2"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been resolved!

versionPriority: 100,
},
},
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: add a new line

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has been resolved!

@SkySingh04 SkySingh04 force-pushed the feature/add-metrics-server-support branch from bd384bf to 9d5d629 Compare February 10, 2025 10:28
@akashsinghvance
Copy link

akashsinghvance commented Feb 10, 2025

@slashpai The asset files are being generated successfully!

Screenshot 2025-02-10 at 4 16 34 PM

@akashsinghvance
Copy link

@slashpai We are ready for review!

Screenshot 2025-02-10 at 5 01 05 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants