Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JS Generator Identifier when name is camel case #9775

Closed
wants to merge 11 commits into from

Conversation

nnnnoel
Copy link

@nnnnoel nnnnoel commented Apr 12, 2022

This PR fixes JS Generator when field name is camel case
protocolbuffers/protobuf-javascript#17

example

message Message {
    int32 someCamelCaseMessage = 1;
}

@google-cla
Copy link

google-cla bot commented Apr 12, 2022

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

@nnnnoel
Copy link
Author

nnnnoel commented Apr 18, 2022

@acozzette can you review about this?

@perezd perezd requested a review from lukesandberg April 18, 2022 23:09
@perezd
Copy link
Contributor

perezd commented Apr 18, 2022

@lukesandberg is responsible for JS, and you'll need to sign the CLA before we can continue w/ review.

@nnnnoel
Copy link
Author

nnnnoel commented Apr 19, 2022

@perezd I signed CLA 7 days ago

@nnnnoel
Copy link
Author

nnnnoel commented May 16, 2022

moved to protocolbuffers/protobuf-javascript#3

@acozzette acozzette closed this May 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants