Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip template tests on .NET 6.0 image #320

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Skip template tests on .NET 6.0 image #320

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
400caf0
Skip template tests on .NET 6.0 image
julienp Nov 13, 2024
d063f63
remove debug assertion
julienp Nov 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,7 @@ jobs:
docker run \
-e RUN_CONTAINER_TESTS=true \
-e IMAGE_VARIANT=pulumi-debian-${{ matrix.sdk }} \
-e LANGUAGE_VERSION=${{ matrix.language_version }} \
-e SDKS_TO_TEST=${SDKS_TO_TEST} \
-e PULUMI_ACCESS_TOKEN=${PULUMI_ACCESS_TOKEN} \
-e PULUMI_ORG=${PULUMI_ORG} \
Expand Down Expand Up @@ -521,6 +522,7 @@ jobs:
docker run \
-e RUN_CONTAINER_TESTS=true \
-e IMAGE_VARIANT=pulumi-ubi-${{ matrix.sdk }} \
-e LANGUAGE_VERSION=${{ matrix.language_version }} \
-e SDKS_TO_TEST=${SDKS_TO_TEST} \
-e PULUMI_ACCESS_TOKEN=${PULUMI_ACCESS_TOKEN} \
-e PULUMI_ORG=${PULUMI_ORG} \
Expand Down
11 changes: 9 additions & 2 deletions tests/containers_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,8 @@ func TestPulumiTemplateTests(t *testing.T) {

stackOwner := mustEnv(t, "PULUMI_ORG")

languageVersion := os.Getenv("LANGUAGE_VERSION") // Not set for kitchen sink

sdksToTest := []string{"csharp", "python", "typescript", "go", "java"}
if os.Getenv("SDKS_TO_TEST") != "" {
sdksToTest = strings.Split(os.Getenv("SDKS_TO_TEST"), ",")
Expand All @@ -80,10 +82,15 @@ func TestPulumiTemplateTests(t *testing.T) {

testCases := []testCase{}
for _, sdk := range sdksToTest {
// python, typescript, ...
if sdk == "csharp" && languageVersion == "6.0" {
// .NET 6.0 is not supported by our templates anymore.
// require.True(t, false)
julienp marked this conversation as resolved.
Show resolved Hide resolved
continue
}
// Base language templates: python, typescript, ...
testCases = append(testCases, testCase{sdk, map[string]string{}})
for _, cloud := range clouds {
// azure-python, aws-python, ...
// Cloud templates azure-python, aws-python, ...
if sdk == "typescript" && cloud == "azure" {
// We use docker & qemu to run arm64 images, and azure seems to be too large
// to successfully run in that environment.
Expand Down