Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip template tests on .NET 6.0 image #320

Merged
merged 2 commits into from
Nov 13, 2024
Merged

Skip template tests on .NET 6.0 image #320

merged 2 commits into from
Nov 13, 2024

Conversation

julienp
Copy link
Contributor

@julienp julienp commented Nov 13, 2024

Our templates have been updated to use .NET 8.0, so they won't run anymore on .NET 6.0.

@julienp julienp added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Nov 13, 2024
Our templates have been updated to use .NET 8.0
@julienp julienp marked this pull request as ready for review November 13, 2024 14:41
@julienp julienp requested a review from a team as a code owner November 13, 2024 14:41
@julienp julienp self-assigned this Nov 13, 2024
@julienp julienp added this to the 0.113 milestone Nov 13, 2024
tests/containers_test.go Outdated Show resolved Hide resolved
@julienp julienp merged commit 5d9bc66 into main Nov 13, 2024
43 checks passed
@julienp julienp deleted the julienp/dotnet6 branch November 13, 2024 15:49
julienp added a commit that referenced this pull request Nov 18, 2024
Pass through the language version, so we can skip the donet template tests when running on dotnet 6.0. Our templates have been updated to use 8.0

Follow up to #320 which updated the PR workflow, but not the release workflow.
julienp added a commit that referenced this pull request Nov 19, 2024
Pass through the language version, so we can skip the donet template
tests when running on dotnet 6.0. Our templates have been updated to use
8.0

Follow up to #320
which updated the PR workflow, but not the release workflow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants