Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] deleted the lines that should have been deleted #935

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

EveCharbie
Copy link
Collaborator

@EveCharbie EveCharbie commented Mar 3, 2025

This change is Reviewable

Copy link

codecov bot commented Mar 5, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.95%. Comparing base (f3b330a) to head (ee2ea15).
Report is 34 commits behind head on master.

Files with missing lines Patch % Lines
...examples/torque_driven_ocp/example_soft_contact.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #935      +/-   ##
==========================================
+ Coverage   77.79%   77.95%   +0.16%     
==========================================
  Files         157      157              
  Lines       18071    18135      +64     
==========================================
+ Hits        14059    14138      +79     
+ Misses       4012     3997      -15     
Flag Coverage Δ
unittests 77.95% <80.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EveCharbie EveCharbie changed the title [WIP] deleted the lines that should have been deleted [RTR] deleted the lines that should have been deleted Mar 5, 2025
@EveCharbie
Copy link
Collaborator Author

@pariterre could you please review this carefully and make sure that what I did is in line with what you ment by that comment ?
@Ipuch I think you would be interested to see what I did with the soft contact function.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant