Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My team has been using this pinot driver with the SQL Alchemy ORM and ran into a bit of an issue with missing table names in
JOIN
clauses during execution.When printing the generated query things look good:
but when executing the query the table names are dropped from all the columns:
and we end up with a query that won't run because the
ON a = a
portion of theJOIN
clause is ambiguous.I checked the commit history for the lines I deleted and didn't learn much about their origin. Is it possible Pinot has advanced in the years since they were originally written? We've moved our code over to our fork of the driver and haven't noticed any side effects yet.
If this solution is unacceptable please let me know what I need to change.
After making the first change we noticed some queries that used to work started failing. The Pinot query planner started returning errors about
CAST
calls using invalid types. I've switchedSTRING
toVARCHAR
andLONG
toNUMERIC
and have updated the tests to reflect that.