Replace plugin.args_invariant_decorator_callback with use of ParamSpec #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c, to support mypy 1.7
Closed
oremanj
force-pushed
the
support-mypy17
branch
3 times, most recently
from
7fa3498
to
8db07b5
Compare
oremanj
force-pushed
the
support-mypy17
branch
from
8db07b5
to
b712386
Compare
CoolCat467
approved these changes
Dec 1, 2023
|
I solemnly swear that all of the statistics classes were copy-pasted from current trio. :-) stubtest is happy so I think there's relatively little that could be incorrect. |
A5rocks
approved these changes
Dec 1, 2023
| class _IOStatistics: | ||
| tasks_waiting: int = attr.ib() | ||
| monitors: int = attr.ib() | ||
| backend: Literal["kqueue"] = attr.ib(init=False, default="kqueue") |
There was a problem hiding this comment.
I don't think init=False or default matters for these but tbh probably fine to keep
There was a problem hiding this comment.
init= impacts the signature of the generated __init__ which stubtest will notice mismatches in
CoolCat467
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #90, a regression that appeared with mypy 1.7. In order to have ParamSpec available, we now require at least mypy 1.0.
args_invariant_decorator_callbackis modeled off the mypycontextlibplugin which was replaced with use of ParamSpec in Oct 2022 (python/mypy@3108669); mypy 1.0 came out in Feb 2023.The test described in #90 no longer fails now that this hook has been removed.
While we're here, update stubs to be consistent with Trio's new inline stubs to satisfy CI. This included:
__aexit__instead of using a star-args shortcut