Skip to content

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 28, 2025

Stacked PRs:


[mxfp8 moe training] integrate blocked scale kernels into training code

Summary

  • integrate triton kernels for converting scales to blocked format into training code
  • wrap triton kernels in custom ops for compile composability
  • uncomment fp8 rowwise test, which was previously left commented

Test plan

  • sanitize pytest test/prototype/moe_training/test_training.py -s

stack-info: PR: #2886, branch: danielvegamyhre/stack/62
… scales

stack-info: PR: #2894, branch: danielvegamyhre/stack/63
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
stack-info: PR: #2900, branch: danielvegamyhre/stack/65
Copy link

pytorch-bot bot commented Aug 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2900

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1032499 with merge base f0cca99 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/65 branch from aa5e4bb to 1032499 Compare August 28, 2025 16:49
@danielvegamyhre danielvegamyhre added mx topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Aug 28, 2025
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from fd521e8 to a2ff75b Compare August 28, 2025 17:18
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/64 to main August 28, 2025 17:26
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/64 August 28, 2025 17:27
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from fd521e8 to a12b575 Compare August 28, 2025 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. mx topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant