Skip to content

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 28, 2025

Stacked PRs:


[mxfp8 moe training] use dim1 cast cuda kernel in bwd

This way we can eliminate the .contiguous() call, as well as use the dim1 cast CUDA kernel which is the fastest option (vs inductor codgen or triton).

Copy link

pytorch-bot bot commented Aug 28, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2897

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 2 Cancelled Jobs, 4 Pending

As of commit e64d4b5 with merge base 83a20c7 (image):

CANCELLED JOBS - The following jobs were cancelled. Please retry:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from c4c957f to 9c2f8a2 Compare August 28, 2025 15:08
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 28, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 15:13
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from 9c2f8a2 to e8e19bc Compare August 28, 2025 15:13
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 15:13
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/63 branch from f451be2 to 95c3e51 Compare August 28, 2025 15:15
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from e8e19bc to 22facfa Compare August 28, 2025 15:15
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 15:30
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from 22facfa to fd521e8 Compare August 28, 2025 15:30
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 15:30
@danielvegamyhre danielvegamyhre added mx topic: not user facing Use this tag if you don't want this PR to show up in release notes labels Aug 28, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 16:49
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 16:49
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 17:18
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from fd521e8 to a2ff75b Compare August 28, 2025 17:18
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 17:18
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 17:26
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from a2ff75b to fd521e8 Compare August 28, 2025 17:26
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 17:26
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 19:34
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from fd521e8 to a12b575 Compare August 28, 2025 19:34
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 19:34
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 28, 2025 21:38
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from a12b575 to 2ea5a0a Compare August 28, 2025 21:38
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/63 August 28, 2025 21:38
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/63 branch from c388a0e to 0f0598a Compare August 28, 2025 21:42
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from 2ea5a0a to 843448d Compare August 28, 2025 21:42
danielvegamyhre added a commit that referenced this pull request Aug 29, 2025
stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from 843448d to 02e246a Compare August 29, 2025 17:16
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/63 to main August 29, 2025 17:16
MXGemmKernelChoice,
ScaleCalculationMode,
)
from torchao.prototype.mx_formats.mx_linear import _to_mxfp8_dim1_kernel_wrapper
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: move to utils file if you want to reuse it

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

stack-info: PR: #2897, branch: danielvegamyhre/stack/64
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/64 branch from 02e246a to e64d4b5 Compare August 29, 2025 18:53
@danielvegamyhre danielvegamyhre merged commit 083d0c3 into main Aug 29, 2025
16 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. mx topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants