Skip to content

Conversation

danielvegamyhre
Copy link
Contributor

@danielvegamyhre danielvegamyhre commented Aug 26, 2025

Stacked PRs:


[mxfp8 moe training] add grouped gemm benchmark script

Usage

  • python benchmarks/prototype/moe_training/bench_2d-3d_grouped_gemm.py

Summary

  • Delete old grouped gemm benchmark script, add new cleaner one.
  • Result on llama4 shapes:
    • bf16 = ~1550us
    • mxfp8 = ~1370 us (optimization work to do here...)

Copy link

pytorch-bot bot commented Aug 26, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/ao/2882

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

danielvegamyhre added a commit that referenced this pull request Aug 26, 2025
stack-info: PR: #2882, branch: danielvegamyhre/stack/61
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from 48a1e85 to a642e55 Compare August 26, 2025 21:55
@meta-cla meta-cla bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Aug 26, 2025
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 26, 2025 22:01
danielvegamyhre added a commit that referenced this pull request Aug 26, 2025
stack-info: PR: #2882, branch: danielvegamyhre/stack/61
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from a642e55 to 16f5bef Compare August 26, 2025 22:01
@danielvegamyhre danielvegamyhre added the topic: not user facing Use this tag if you don't want this PR to show up in release notes label Aug 26, 2025
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 26, 2025 22:01
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 02:57
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 02:57
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 15:42
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 15:43
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 15:53
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 15:53
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 16:08
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 16:08
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 16:23
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from 16f5bef to ba16729 Compare August 27, 2025 16:23
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 16:23
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 16:28
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 16:29
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 19:10
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 19:10
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/60 branch from ac6f4f1 to 9f8ac6b Compare August 27, 2025 20:39
danielvegamyhre added a commit that referenced this pull request Aug 27, 2025
stack-info: PR: #2882, branch: danielvegamyhre/stack/61
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from ba16729 to 92defca Compare August 27, 2025 20:39
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 20:53
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from 92defca to baf6583 Compare August 27, 2025 20:54
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 20:54
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 21:20
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from baf6583 to a08719c Compare August 27, 2025 21:21
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 21:21
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 27, 2025 21:31
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 27, 2025 21:31
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 00:42
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 28, 2025 00:42
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 01:19
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 28, 2025 01:19
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 01:23
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 28, 2025 01:23
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 01:55
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 28, 2025 01:55
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 04:06
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 28, 2025 04:06
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 15:08
@danielvegamyhre danielvegamyhre changed the base branch from main to danielvegamyhre/stack/60 August 28, 2025 15:08
danielvegamyhre added a commit that referenced this pull request Aug 28, 2025
stack-info: PR: #2882, branch: danielvegamyhre/stack/61
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from a08719c to b755921 Compare August 28, 2025 15:09
stack-info: PR: #2882, branch: danielvegamyhre/stack/61
@danielvegamyhre danielvegamyhre changed the base branch from danielvegamyhre/stack/60 to main August 28, 2025 15:13
@danielvegamyhre danielvegamyhre force-pushed the danielvegamyhre/stack/61 branch from b755921 to 3740cbe Compare August 28, 2025 15:13
@danielvegamyhre danielvegamyhre merged commit f0cca99 into main Aug 28, 2025
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. mx topic: not user facing Use this tag if you don't want this PR to show up in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants