-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spacemouse debugging #23
Conversation
also can you fix the pre-commit failing ? |
Thanks for the test script. Just run |
These are a lot of commits for a minor change. It might help to squash-and-merge instead of the default. |
|
||
""" | ||
import time | ||
import numpy as np |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import should be on top of the file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I misunderstood then. You want imports to be on top, but the setting of numpy
precision options to be in the test? both of these are global changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can set print options in the test and reset it with np.set_printoptions()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import should always go to the top of a py file,
np print precesion is local to your function, e.g., you can change in another function; so it should go to the function which actually needs it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np print precision is not local. But we can make it local with a context manager. just pushed a change
Add a test file to debug spacemouse output