PCB: better logging for demo collection #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youliangtan
reviewed
Feb 20, 2024
| with open(file_name, "wb") as f: | ||
| pkl.dump(transitions, f) | ||
| print(f"saved {success_needed} demos to {file_name}") | ||
| file_name = f"./pcb_insert_{success_needed}_demos_{uuid}.pkl" |
There was a problem hiding this comment.
Is it easier if we check the dir exists beforehand? else create the dir if it doesnt exist. something like
if os.path.exists(DATA_DIRECTORY):
shutil.rmtree(DATA_DIRECTORY)
os.makedirs(DATA_DIRECTORY)There was a problem hiding this comment.
Sure. We need to check if the dir exists, and whether we have write permission to that dir. We can start recording only after this check completes. Is that a preferable solution?
Also, I don't think we should do an shutil.rmtree on any users machine. The user might be storing demo files in the same directory as other code or files.
There was a problem hiding this comment.
Yes, just create the dir is suffice and maybe check the write permission too.
ahh yes, you are right, we shouldnt do rmtree, I copied this code snippet from another codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.