-
Notifications
You must be signed in to change notification settings - Fork 126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translated Lists-and-Keys page #25
Conversation
aliana17
commented
Mar 21, 2019
•
edited by arshadkazmi42
Loading
edited by arshadkazmi42
- कई कौम्पोनॅन्टस को रेंडर करना
- मूल लिस्टस कौम्पोनॅन्ट
- Keys
- key के साथ कंपोनेंट्स निकालना
- keys सिर्फ़ भाई-बहनों के बीच अद्वितीय होनी चाहिए
- JSX में मैप की एम्बेडिंग
Deploy preview for hi-reactjs ready! Built with commit 730d233 |
Deploy preview for hi-reactjs ready! Built with commit 9e277a7 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great.
I have started the review.
I have added the feedback till line 100. Once you are done fixing those, we can continue with a review of the next parts of the translation.
Please do go through the review process (here #23) which we follow.
You can make the suggested changes and add an 👍 emoji to acknowledge it, the reviewer will review the changes and they will resolve the feedback
@anchal7299 Any updates on this, let us know if you need any help from our end with the translation |
Thank you for the support.I have made the changes as per feedback.
|
@anchal7299 Great work, there is some more comments I have added in the same feedback. |
👍
…On Thu, Mar 28, 2019 at 8:23 AM Arshad Kazmi ***@***.***> wrote:
@anchal7299 <https://github.com/anchal7299> Great work, there is some
more comments I have added in the same feedback.
Can you have a look at the feedbacks which are not resolved.
Also mark every feedback with 👍 emoji, once you have fixed it, so it
will be easy for us during review.
Once you are done with these changes, I will start review of rest of the
translation
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ar9xg1XISU5YmzJgUmxGZD72HhVM2bSpks5vbC6ogaJpZM4cA91J>
.
|
@anchal7299 Great going, there are few more changes which broke during other changes, once you are done with those changes I can start reviewing reset of the translation |
@anchal7299 There is only 1 change pending for this review, then I will start with next part of the translation review |
Sir,
My git push command is not working.
Initially it was working well but now I am getting a TaskCanceledException
when i use git push origin lists-and-keys
Please help me out in resolving this issue.
…On Thu, Apr 4, 2019 at 10:50 PM Arshad Kazmi ***@***.***> wrote:
@anchal7299 <https://github.com/anchal7299> There is only 1 change
pending for this review, then I will start with next part of the
translation review
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ar9xgwGxnt1ouHTA2rqgCCJcNTmW-Dabks5vdjRlgaJpZM4cA91J>
.
|
Are you using Windows? Can you try this |
Thanks, it worked.
…On Tue, Apr 9, 2019 at 8:07 AM Arshad Kazmi ***@***.***> wrote:
Are you using Windows?
Can you try this
https://stackoverflow.com/a/36421510/3136282
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ar9xg26mfi5zO1zIbqMk14sUe1qbLKIEks5ve_zygaJpZM4cA91J>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work till now and thank you for your patience with the feedback implementation.
I have added a couple of more feedbacks, once these are fixed it will be good to go from my end.
done till line 100 |
done till {#extracting-components-with-keys} |
content/docs/lists-and-keys.md
Outdated
|
||
Keys only make sense in the context of the surrounding array. | ||
Keys केवल उनके array के लिए ही होती है। |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
incorrect translation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not getting it's correct translation . Please suggest it's hindi translation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keys केवल आस-पास के array के संदर्भ में ही समझ में आती हैं।
done till {#embedding-map-in-jsx} |
Awesome work @anchal7299 ! Thank you! And merging this in. |
Thanks
…On 04-Jun-2019 3:32 am, "Saransh Kataria" ***@***.***> wrote:
Merged #25 <#25> into
master.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#25>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AK7XDA4CSYBCMUNN4632RODPYWIF5ANCNFSM4HAD3VEQ>
.
|