feat(poetry): support GCloud credentials for Google Artifact Registry when locking #32586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viceice
previously requested changes
Nov 18, 2024
maxbrunet
force-pushed
the
feat/poetry/lock-gar
branch
from
e365586 to
2320159
Compare
|
An other review for this one? 🙏 |
rarkins
requested changes
Dec 18, 2024
Co-authored-by: Rhys Arkins <[email protected]>
rarkins
approved these changes
Dec 18, 2024
|
Kindly asking for extra reviews or a merge 🙂🙏 |
|
🎉 This PR is included in version 39.95.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Detect Google Artifact Registry URL and pass GCloud Oauth credentials via
POETRY_HTTP_BASIC_*environment variables when runningpoetry lockContext
Similar to #32545 for uv
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: