[ROOT-1030] Remove immutable fields from docs and payload, and add deprecation warning to Resource. #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azanar
force-pushed
the
ed/ROOT-1030/remove_immutable_fields_from_role_resource
branch
from
d527b4a to
4a68c23
Compare
…precation warning to Resource.
azanar
force-pushed
the
ed/ROOT-1030/remove_immutable_fields_from_role_resource
branch
from
4a68c23 to
7604bc5
Compare
nronas
requested changes
Oct 24, 2024
|
Most of the code for the provider is generated using the OpenAPI schema. Changes to the .go source for most things will be overwritten in the build step. I'll add a comment to the top of auto-generated files. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The API ignores
is_deletableandis_editablesettings from incoming payloads.See: https://github.com/rootlyhq/rootly/blob/development/app/controllers/api/v1/roles_controller.rb#L54-L88
Note the absence of these two fields. 😁
This deprecates them instead of removing them outright, to avoid breaking existing TF configurations.
It looks like theTestAccResourceCustomFieldOptionsuite is failing, due to something unhappy over on the Rootly API side. Not sure which API key this uses, so I'd kind of be flying blind.Nevermind. Flaky test is flaky. Not exclusive to our Rails app. 😁