Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add build support for melodic #63

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdrianZw
Copy link

@AdrianZw AdrianZw commented Jul 7, 2020

Resolves several issues on melodic, e.g. the class MoveGroup is removed in Melodic. Besides, issue #41 was resolved for me, since FindHDF5.cmake is used.
The branch needsto be tested on Kinetic and Noetic though.

@p0rys
Copy link

p0rys commented Jul 21, 2020

First, thank you for porting this package to melodic!
I tried to build it with your commit and get the following error:

/catkin_ws/src/reuleaux/map_creator/include/map_creator/kinematics.h:9:10: fatal error: evoid_manipulator_ikfast_solver.cpp: Datei oder Verzeichnis nicht gefunden (File or Directory not found)
#include "evoid_manipulator_ikfast_solver.cpp"

Is it possible that the commit is missing a new added file for the changes in Line 6 & 9 in map_creator/include/map_creator/kinematics.h ?

@AdrianZw
Copy link
Author

AdrianZw commented Jul 21, 2020 via email

@sandakalum
Copy link

Thanks for adding build support for melodic, I was able to build on melodic. But when trying to add the Base Placement Plug-in panel in Rviz, it dies with 'Segmentation fault (core dumped)'. Any ideas?

@marktkram
Copy link

marktkram commented Aug 30, 2021

Not sure if this is still active but your patch helped me a lot to get it running on melodic and should be merged :)
if you add qt5 support to the base_placment_plugin/CMakeLists.txt the plugin doesn't crash on startup.

if(rviz_QT_VERSION VERSION_LESS "5")
  find_package(Qt4 ${rviz_QT_VERSION} REQUIRED QtCore QtGui)
  include(${QT_USE_FILE})
  set(QT_LIBRARIES )
else()
  find_package(Qt5 ${rviz_QT_VERSION} REQUIRED Core Widgets Concurrent)
  set(QT_LIBRARIES Qt5::Core Qt5::Widgets Qt5::Concurrent)
endif()
# Instruct CMake to run moc automatically when needed.
set(CMAKE_AUTOMOC ON)
if(rviz_QT_VERSION VERSION_LESS "5")
  qt4_wrap_cpp(base_placement_plugin_MOCS ${base_placement_plugin_HDRS} )
  qt4_wrap_ui(base_placement_plugin_UIS_H ${base_placement_plugin_UIS} )
else()
  qt5_wrap_cpp(base_placement_plugin_MOCS ${base_placement_plugin_HDRS} )
  qt5_wrap_ui(base_placement_plugin_UIS_H ${base_placement_plugin_UIS} )
endif()


include_directories(${base_placement_plugin_INCLUDE_DIRECTORIES} ${catkin_INCLUDE_DIRS} ${HDF5_INCLUDE_DIRS})
add_library(${PROJECT_NAME} ${base_placement_plugin_SRCS} ${base_placement_plugin_MOCS} ${base_placement_plugin_UIS_H}) # ${base_placement_plugin_UIS_H}
target_link_libraries(${PROJECT_NAME} ${catkin_LIBRARIES} ${QT_QTCORE_LIBRARY} ${QT_QTGUI_LIBRARY} ${QT_LIBRARIES} yaml-cpp ${HDF5_LIBRARIES} create_marker)
## target_link_libraries(${PROJECT_NAME} yaml-cpp)

Unfortunately i can't test this on kinetic

kbrameld added a commit to kbrameld/reuleaux that referenced this pull request Feb 18, 2023
sjulier added a commit to sjulier/reuleaux that referenced this pull request Apr 5, 2023
@liyuping0906
Copy link

@AdrianZw Hello, is there a noetic version of Reuleaux? I've tried compiling reuleaux on noetic but it hasn't worked. Thank you so much

@AdrianZw
Copy link
Author

AdrianZw commented Jul 26, 2024

@liyuping0906 Now it does, see https://github.com/AdrianZw/reuleaux/tree/noetic-devel/map_creator. At least it compiled and the map executor run on Ubuntu 22.04 with Noetic

I also added the fixes suggested by @marktkram

I fixed a failing unit test, but I am not really sure if everything still works. Haven't used that tool in a longer time.

Is there a maintainer for this repo?

Not sure how to proceed with this... MR #73 instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants