Code

Asset event attrs in dom#1433

Code

Closed

eoghanmurray wants to merge 102 commits intorrweb-io:masterrrweb-io/rrweb:masterfrom eoghanmurray:asset-event-attrs-in-domeoghanmurray/rrweb:asset-event-attrs-in-domCopy head branch name to clipboard

+5,914-2,351

Commits

Commits on Apr 22, 2024

• Add Asset event type and capture assets

  

  Juice10

  authored and

  eoghanmurray

  committed
  63da3e2

  Copy full SHA for 63da3e2

• Add test to prove player works

  

  Juice10

  authored and

  eoghanmurray

  committed
  ddab1da

  Copy full SHA for ddab1da

• Rename assetCaptureConfig to assetCapture

  

  Juice10

  authored and

  eoghanmurray

  committed
  16d89db

  Copy full SHA for 16d89db

• Document assetCapture config

  

  Juice10

  authored and

  eoghanmurray

  committed
  2986546

  Copy full SHA for 2986546

• Create asset event for assets that failed to load

  

  Juice10

  authored and

  eoghanmurray

  committed
  401b2fd

  Copy full SHA for 401b2fd

• Allow other yarn dev commands to depend on @rrweb/types

  

  Juice10

  authored and

  eoghanmurray

  committed
  0ffb619

  Copy full SHA for 0ffb619

• Move types from rrweb-snapshot to @rrweb/types

  Show description for 2fab181
  

  Juice10

  authored and

  eoghanmurray

  committed
  2fab181

  Copy full SHA for 2fab181

• Remove unused import statement

  

  Juice10

  authored and

  eoghanmurray

  committed
  57d4619

  Copy full SHA for 57d4619

• WIP asset manager for replay

  

  Juice10

  authored and

  eoghanmurray

  committed
  2f76fae

  Copy full SHA for 2f76fae

• NodeType was moved to @rrweb/types

  

  Juice10

  authored and

  eoghanmurray

  committed
  56f5aa8

  Copy full SHA for 56f5aa8

• Add placeholder tests

  

  Juice10

  authored and

  eoghanmurray

  committed
  cbeeb01

  Copy full SHA for cbeeb01

• Fix image source attribute in rebuild function

  

  Juice10

  authored and

  eoghanmurray

  committed
  a18d0e6

  Copy full SHA for a18d0e6

• Update path in tsconfig.json

  

  Juice10

  authored and

  eoghanmurray

  committed
  ae020d7

  Copy full SHA for ae020d7

• Fix asset loading in Replayer

  

  Juice10

  authored and

  eoghanmurray

  committed
  d3c7b7e

  Copy full SHA for d3c7b7e

• Add todo tests

  

  Juice10

  authored and

  eoghanmurray

  committed
  841cd8c

  Copy full SHA for 841cd8c

• Add asset mutation events for replayer test

  

  Juice10

  authored and

  eoghanmurray

  committed
  607ce6d

  Copy full SHA for 607ce6d

• Add replay for cached asset on attribute changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  e4ecc0a

  Copy full SHA for e4ecc0a

• Add isAttributeCacheable and manageAttribute

  Show description for 12c18e6
  

  Juice10

  authored and

  eoghanmurray

  committed
  12c18e6

  Copy full SHA for 12c18e6

• Move assetCapture params to @rrweb/types and add them to meta events

  

  Juice10

  authored and

  eoghanmurray

  committed
  99d2b21

  Copy full SHA for 99d2b21

• Add asset capture config to meta events

  

  Juice10

  authored and

  eoghanmurray

  committed
  645c75a

  Copy full SHA for 645c75a

• NodeType was moved to @rrweb/types

  

  Juice10

  authored and

  eoghanmurray

  committed
  046d179

  Copy full SHA for 046d179

• NodeType was moved to @rrweb/types

  

  Juice10

  authored and

  eoghanmurray

  committed
  d3694f7

  Copy full SHA for d3694f7

• Upgrade jest and rollup in rrweb-snapshot

  

  Juice10

  authored and

  eoghanmurray

  committed
  66e13e0

  Copy full SHA for 66e13e0

• Add check types

  

  Juice10

  authored and

  eoghanmurray

  committed
  67a779e

  Copy full SHA for 67a779e

• Update snapshots to include assetCapture settings

  

  Juice10

  authored and

  eoghanmurray

  committed
  71d87d4

  Copy full SHA for 71d87d4

• Mark inlineImages as deprecated in favor of assetCapture

  

  Juice10

  authored and

  eoghanmurray

  committed
  5b4a5b5

  Copy full SHA for 5b4a5b5

• Fix rrdom build

  

  Juice10

  authored and

  eoghanmurray

  committed
  180f7fd

  Copy full SHA for 180f7fd

• Fix deprecated test

  

  Juice10

  authored and

  eoghanmurray

  committed
  015e412

  Copy full SHA for 015e412

• Rename assetCapture to captureAssets

  Show description for 27663f3
  

  Juice10

  authored and

  eoghanmurray

  committed
  27663f3

  Copy full SHA for 27663f3

• Remove console.log statements from AssetManager

  Show description for b873923
  

  Juice10

  authored and

  eoghanmurray

  committed
  b873923

  Copy full SHA for b873923

• Check if url is of cacheable origin

  

  Juice10

  authored and

  eoghanmurray

  committed
  f1c263b

  Copy full SHA for f1c263b

• Test: Add captureAssets config to meta event

  

  Juice10

  authored and

  eoghanmurray

  committed
  ffa46d5

  Copy full SHA for ffa46d5

• object urls aren't stable so lets remove them

  

  Juice10

  authored and

  eoghanmurray

  committed
  db94765

  Copy full SHA for db94765

• inlineImages should work next to captureAssets for now

  

  Juice10

  authored and

  eoghanmurray

  committed
  634c1ae

  Copy full SHA for 634c1ae

• Fix asset caching bug

  

  Juice10

  authored and

  eoghanmurray

  committed
  d756e61

  Copy full SHA for d756e61

• captureAssets on live-stream by default

  

  Juice10

  authored and

  eoghanmurray

  committed
  7ae4dd4

  Copy full SHA for 7ae4dd4

• Fix asset URLs in events file

  

  Juice10

  authored and

  eoghanmurray

  committed
  c1d73ce

  Copy full SHA for c1d73ce

• Update deprecated inlineImages option to use

  Show description for f0050df
  eoghanmurray

  committed
  f0050df

  Copy full SHA for f0050df

• Deprecate inlineImage config

  Show description for 37af341
  

  Juice10

  authored and

  eoghanmurray

  committed
  37af341

  Copy full SHA for 37af341

• Update snapshot to reflect current captureAssets

  

  Juice10

  authored and

  eoghanmurray

  committed
  c47f9cd

  Copy full SHA for c47f9cd

• Make test less flaky

  

  Juice10

  authored and

  eoghanmurray

  committed
  c171342

  Copy full SHA for c171342

• Cache attribute support for BODY, TABLE,

  Show description for d5364e5
  

  Juice10

  authored and

  eoghanmurray

  committed
  d5364e5

  Copy full SHA for d5364e5

• Remove unused 'inlineImages' option

  

  Juice10

  authored and

  eoghanmurray

  committed
  7c43890

  Copy full SHA for 7c43890

• Refactor AssetManager constructor signature

  

  Juice10

  authored and

  eoghanmurray

  committed
  2ab47a2

  Copy full SHA for 2ab47a2

• Remove console.log statements in asset.test.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  6546dbd

  Copy full SHA for 6546dbd

• Refactor reset method signature to accept optional

  Show description for 55c24fa
  

  Juice10

  authored and

  eoghanmurray

  committed
  55c24fa

  Copy full SHA for 55c24fa

• Fix deserialized size comparison in deserializeArg

  Show description for fa6e086
  

  Juice10

  authored and

  eoghanmurray

  committed
  fa6e086

  Copy full SHA for fa6e086

• Apply formatting changes

  

  Juice10

  authored and

  eoghanmurray

  committed
  5516780

  Copy full SHA for 5516780

• Fix asset manager to only load assets from

  Show description for 8598eab
  

  Juice10

  authored and

  eoghanmurray

  committed
  8598eab

  Copy full SHA for 8598eab

• Add cacheRoot option to typescript plugin in

  Show description for 2c12cab
  

  Juice10

  authored and

  eoghanmurray

  committed
  2c12cab

  Copy full SHA for 2c12cab

• Add cacheRoot option to tsconfigOverride in

  Show description for 2a25fec
  

  Juice10

  authored and

  eoghanmurray

  committed
  2a25fec

  Copy full SHA for 2a25fec

• Update defaultPort in startServer function

  

  Juice10

  authored and

  eoghanmurray

  committed
  44fbc10

  Copy full SHA for 44fbc10

• Make test more reliable

  

  Juice10

  authored and

  eoghanmurray

  committed
  445c7bb

  Copy full SHA for 445c7bb

• Add failing test for src attribute

  

  Juice10

  authored and

  eoghanmurray

  committed
  9bc508a

  Copy full SHA for 9bc508a

• Remove failed asset event

  

  Juice10

  authored and

  eoghanmurray

  committed
  a236dea

  Copy full SHA for a236dea

• Add support for asset manager in rrdom

  Show description for 6bc2164
  

  Juice10

  authored and

  eoghanmurray

  committed
  6bc2164

  Copy full SHA for 6bc2164

• Change asset manager path

  

  Juice10

  authored and

  eoghanmurray

  committed
  9c8a2fc

  Copy full SHA for 9c8a2fc

• Fix import path for AssetManager in asset-unit.test.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  4a937aa

  Copy full SHA for 4a937aa

• Move isAttributeCacheable tests to rrweb-snapshot

  

  Juice10

  authored and

  eoghanmurray

  committed
  a2d91b8

  Copy full SHA for a2d91b8

• Make assetManager optional

  

  Juice10

  authored and

  eoghanmurray

  committed
  d81d6d3

  Copy full SHA for d81d6d3

• upgrade rrdom-nodejs to jest 29

  

  Juice10

  authored and

  eoghanmurray

  committed
  a4d7bdb

  Copy full SHA for a4d7bdb

• Update Jest and ts-jest versions to 29 in rrvideo

  

  Juice10

  authored and

  eoghanmurray

  committed
  99a22ce

  Copy full SHA for 99a22ce

• add @types/prettier dependency

  

  Juice10

  authored and

  eoghanmurray

  committed
  b729dc9

  Copy full SHA for b729dc9

• Update tsconfig.json files with Node module resolution

  

  Juice10

  authored and

  eoghanmurray

  committed
  8c69bd7

  Copy full SHA for 8c69bd7

• upgrade dependencies

  

  Juice10

  authored and

  eoghanmurray

  committed
  535a1c2

  Copy full SHA for 535a1c2

• Update jest to 29 and rollup to 4

  

  Juice10

  authored and

  eoghanmurray

  committed
  3fe1e80

  Copy full SHA for 3fe1e80

• Add esModuleInterop and allowSyntheticDefaultImports to tsconfig.json

  

  Juice10

  authored and

  eoghanmurray

  committed
  2593269

  Copy full SHA for 2593269

• Add support for updating srcset attribute in

  Show description for cfb0571
  

  Juice10

  authored and

  eoghanmurray

  committed
  cfb0571

  Copy full SHA for cfb0571

• Add support for SVG elements in AssetManager

  

  Juice10

  authored and

  eoghanmurray

  committed
  faff4b9

  Copy full SHA for faff4b9

• Drop support for caching xlink:href attributes

  Show description for 1abf3dc
  

  Juice10

  authored and

  eoghanmurray

  committed
  1abf3dc

  Copy full SHA for 1abf3dc

• Fix rrdom error:

  Show description for d7030c0
  

  Juice10

  authored and

  eoghanmurray

  committed
  d7030c0

  Copy full SHA for d7030c0

• Upgrade to jest-environment-jsdom 30-alpha.2

  Show description for c04ef80
  

  Juice10

  authored and

  eoghanmurray

  committed
  c04ef80

  Copy full SHA for c04ef80

• Remove console.log statement in

  Show description for 621f8c5
  

  Juice10

  authored and

  eoghanmurray

  committed
  621f8c5

  Copy full SHA for 621f8c5

• Linux and Mac generate slightly different screenshots

  

  Juice10

  authored and

  eoghanmurray

  committed
  7d7aac8

  Copy full SHA for 7d7aac8

• Add wait for RAF before evaluating snapshots

  

  Juice10

  authored and

  eoghanmurray

  committed
  d1db95e

  Copy full SHA for d1db95e

• Changeset: Added support for Asset Event and capturing many

  Show description for 9fcdeae
  

  Juice10

  authored and

  eoghanmurray

  committed
  9fcdeae

  Copy full SHA for 9fcdeae

• Update puppeteer version in package.json

  

  Juice10

  authored and

  eoghanmurray

  committed
  f5af50b

  Copy full SHA for f5af50b

• Fix cross-origin iframe message forwarding test

  

  Juice10

  authored and

  eoghanmurray

  committed
  cf1f6a3

  Copy full SHA for cf1f6a3

• Make test more robust

  

  Juice10

  authored and

  eoghanmurray

  committed
  085e524

  Copy full SHA for 085e524

• Deprecate inlineImages and introduce captureAssets option

  

  Juice10

  authored and

  eoghanmurray

  committed
  57a167c

  Copy full SHA for 57a167c

• Docs: add examples to getUrlsFromSrcset

  

  Juice10

  authored and

  eoghanmurray

  committed
  cd730d4

  Copy full SHA for cd730d4

• Move @rrweb/types to devDependencies for rrweb-snapshot

  

  Juice10

  authored and

  eoghanmurray

  committed
  9532d77

  Copy full SHA for 9532d77

• Remove console.log statements in asset-integration.test.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  a132f63

  Copy full SHA for a132f63

• Update packages/rrweb/src/replay/asset-manager/index.ts

  Show description for 5c659bd
  

  Juice10

  and

  eoghanmurray

  committed
  5c659bd

  Copy full SHA for 5c659bd

• Delay call until all attributes are present on the new node, in case the AssetManager needs to interrogate other attributes to determine how to manage, e.g. <link with href depending on rel="styles…

  Show description for 34e8047
  eoghanmurray

  committed
  34e8047

  Copy full SHA for 34e8047

• Rename Cacheable -> Capturable

  eoghanmurray

  committed
  07be53c

  Copy full SHA for 07be53c

Commits on Apr 23, 2024

• Indicate the presence of deferred assets using new rr_captured_* attributes instead of storing config on the Meta event

  Show description for a795544
  eoghanmurray

  committed
  a795544

  Copy full SHA for a795544

• Revert attributes in non-live mode and ensure this happens when we can determine that Assets won't be arriving later

  eoghanmurray

  committed
  7806c45

  Copy full SHA for 7806c45

Commits on Apr 24, 2024

• Only record certain iframes as assets as we don't want to override the existing nested iframe mechanism

  eoghanmurray

  committed
  b22ed45

  Copy full SHA for b22ed45

• Fixup: we don't need template strings here

  eoghanmurray

  committed
  cec8313

  Copy full SHA for cec8313

• Ensure we correctly distinguish between html <iframes> and other exotic types that inline images or pdfs

  eoghanmurray

  committed
  ff49d73

  Copy full SHA for ff49d73

• Bump timeouts here as I was getting failures when running whole test suite concurrently

  eoghanmurray

  committed
  90af2c6

  Copy full SHA for 90af2c6

• Add an asset type which includes the element; a bit of prep work for handling stylesheet assets

  eoghanmurray

  committed
  bd10593

  Copy full SHA for bd10593

• This function was replaced by getSourcesFromSrcset which ultimately derives from rrweb-io/rrweb-snapshot#74

  eoghanmurray

  committed
  591698d

  Copy full SHA for 591698d

• Refactor and prepare for some changes: Deal with the difference between srcset and other url attributes in one place

  eoghanmurray

  committed
  fc12a99

  Copy full SHA for fc12a99

• Create assetStatus type as per Justin's request

  eoghanmurray

  committed
  2a45198

  Copy full SHA for 2a45198

• Default to headless on retest

  eoghanmurray

  committed
  bd9d3c6

  Copy full SHA for bd9d3c6

• A convenience command to run prettier against files that have just been committed

  eoghanmurray

  committed
  e9b7f28

  Copy full SHA for e9b7f28

• Fix types as per suggestions from code review

  

  Juice10

  authored and

  eoghanmurray

  committed
  ba9d5a2

  Copy full SHA for ba9d5a2

• Update packages/rrweb/src/replay/canvas/2d.ts

  

  Juice10

  authored and

  eoghanmurray

  committed
  24dc37c

  Copy full SHA for 24dc37c

• Remove function not used since rrweb-io#995

  eoghanmurray

  committed
  2145f52

  Copy full SHA for 2145f52

• Don't rename attrs of assets which will be refused according to initial recording config, i.e. the origins don't match. Should make the 'refused' status redundant

  eoghanmurray

  committed
  1470f1a

  Copy full SHA for 1470f1a