Asset event attrs in dom #1433
Closed
Asset event attrs in dom #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1470f1a The changes in this PR will be included in the next version bump. This PR includes changesets to release 8 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Juice10
reviewed
Mar 26, 2024
Juice10
reviewed
Mar 26, 2024
Juice10
reviewed
Mar 26, 2024
packages/rrweb/test/record/__snapshots__/cross-origin-iframes.test.ts.snap
Outdated
Show resolved
Hide resolved
Juice10
reviewed
Mar 26, 2024
packages/rrweb/test/record/__snapshots__/cross-origin-iframes.test.ts.snap
Outdated
Show resolved
Hide resolved
Juice10
reviewed
Mar 26, 2024
packages/rrweb/test/record/__snapshots__/cross-origin-iframes.test.ts.snap
Outdated
Show resolved
Hide resolved
eoghanmurray
force-pushed
the
asset-event-attrs-in-dom
branch
5 times, most recently
from
5fdfd37 to
dfcfee4
Compare
Juice10
previously requested changes
Apr 4, 2024
There was a problem hiding this comment.
Really loving this @eoghanmurray! I fixed your typing issues for you
Juice10
reviewed
Apr 5, 2024
eoghanmurray
force-pushed
the
asset-event-attrs-in-dom
branch
2 times, most recently
from
e632690 to
5a23bf2
Compare
eoghanmurray
force-pushed
the
asset-event-attrs-in-dom
branch
from
a76f8d3 to
3255a99
Compare
- Fix declaration emit with vite Workaround for qmhc/vite-plugin-dts#193
Co-authored-by: Eoghan Murray <[email protected]>
…the AssetManager needs to interrogate other attributes to determine how to manage, e.g. <link with href depending on rel="stylesheet"
…tributes instead of storing config on the Meta event - a better approach as discussed with Justin and Yanzhen
…n determine that Assets won't be arriving later
eoghanmurray
force-pushed
the
asset-event-attrs-in-dom
branch
3 times, most recently
from
5b07eca to
674ca42
Compare
…e existing nested iframe mechanism
…ic types that inline images or pdfs
…suite concurrently
…r handling stylesheet assets
…en `srcset` and other url attributes in one place
…al recording config, i.e. the origins don't match. Should make the 'refused' status redundant
eoghanmurray
force-pushed
the
asset-event-attrs-in-dom
branch
from
674ca42 to
1470f1a
Compare
This was referenced May 7, 2024
|
This is incorporated into #1475 and doesn't need any further evaluation as we're going to take this approach |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for evaluation by Justin and is an extension of #1239