Skip to content

make OsString::new and PathBuf::new unstably const #141467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cyrgani
Copy link
Contributor

@cyrgani cyrgani commented May 23, 2025

Since #129041, String::into_bytes is const, which allows making OsString::new and PathBuf::new unstably const now.
Not sure what the exact process for this is; does it need an ACP?

@rustbot
Copy link
Collaborator

rustbot commented May 23, 2025

r? @workingjubilee

rustbot has assigned @workingjubilee.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 23, 2025
@workingjubilee
Copy link
Member

Please create a tracking issue for this.

@cyrgani cyrgani force-pushed the const-empty-stringlikes branch from c470edb to fab206b Compare May 24, 2025 20:33
@cyrgani
Copy link
Contributor Author

cyrgani commented May 24, 2025

done (#141520)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants