Skip to content

Update stdarch submodule #141964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Jun 3, 2025
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

⚠️ Warning ⚠️

  • Some commits in this PR modify submodules.

@rust-log-analyzer

This comment has been minimized.

@sayantn
Copy link
Contributor Author

sayantn commented Jun 3, 2025

cc @bjorn3 I guess.

@bjorn3
Copy link
Member

bjorn3 commented Jun 3, 2025

That is caused by rust-lang/stdarch#1807. You can try replacing the llvm.aarch64.neon.frintn.v string in compiler/rustc_codegen_cranelift/src/intrinsics/llvm_aarch64.rs with llvm.roundeven.v and likely move it to compiler/rustc_codegen_cranelift/src/intrinsics/llvm.rs.

 - remove unused `llvm.aarch64.neon.frintn` from cg_clif
@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@rust-log-analyzer

This comment has been minimized.

@rustbot
Copy link
Collaborator

rustbot commented Jun 3, 2025

Portable SIMD is developed in its own repository. If possible, consider making this change to rust-lang/portable-simd instead.

cc @calebzulawski, @programmerjake

The Miri subtree was changed

cc @rust-lang/miri

@Amanieu Amanieu added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jun 4, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 4, 2025

@bors r+ rollup=never

@bors
Copy link
Collaborator

bors commented Jun 4, 2025

📌 Commit fbc15c1 has been approved by Amanieu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 4, 2025
@Amanieu
Copy link
Member

Amanieu commented Jun 4, 2025

Beta-nominating specifically for rust-lang/stdarch#1818: we want that to be backported to beta since we accidentally stabilized some f16 types and intrinsics in beta. However it's not strictly necessary if the FCP on #136306 passes before the release deadline since we would be stabilizing them in the next release anyways.

@adamgemmell
Copy link
Contributor

A minor correction in case it changes something - the f16 types were accidentally introduced originally as stable so those aren't a regression and are currently stable on the stable channel. The couple of f16 intrinsics stabilised are the beta regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-nominated Nominated for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking Issue for AVX512 intrinsics
7 participants