Upgrade raw-window-handle to 0.6.0 #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no longer an `ns_window` member in the new handles, so support for it had to be dropped. At the same time the `ns_view` members are appropriately marked `NonNull<>` so there's no longer a need for this fallback path.
MarijnS95
commented
Oct 11, 2023
Comment on lines
14
to
17
| pub enum Layer { | ||
| Existing(CAMetalLayer), | ||
| Allocated(CAMetalLayer), | ||
| None, | ||
| } |
There was a problem hiding this comment.
In ash-window we have a pattern that takes out the CAMetalLayer. Is there any significance here (e.g. lifetimes) or can we flatten this, store existing vs allocated in a separate member, or add a helper fn value(self) -> CAMetalLayer thing?
There was a problem hiding this comment.
The CAMetalLayer may be allocated in case there couldn't be extracted one from the window handle, and should be destroyed if not needed anymore (on surface destruction). To not leak the consumer should execute sth like msg_send![layer, release] in case of Layer::Allocated(layer) (but couldn't test due to lack of hw)
There was a problem hiding this comment.
Since raw-window-metal maps this nicely, should it also implement Drop that does this for Allocated but not for Existing? Or at least add a doc-comment and perhaps make this an "implementation detail" unless transferring ownership is a thing, which we should make more explicit to the caller?
There was a problem hiding this comment.
I could test these things out soon™, perhaps worth doing that before cutting a new release?
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Oct 14, 2023
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Oct 14, 2023
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
msiglreith
approved these changes
Oct 14, 2023
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Oct 18, 2023
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Oct 23, 2023
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
commented
Oct 31, 2023
| @@ -1,4 +1,4 @@ | |||
| #![cfg(any(target_os = "macos", target_os = "ios"))] | |||
| // #![cfg(any(target_os = "macos", target_os = "ios"))] | |||
There was a problem hiding this comment.
Oops, I think I forgot to drop this even after cross-compiling/building/testing to the right target 😅
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Nov 1, 2023
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Dec 2, 2023
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Mar 16, 2024
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Mar 19, 2024
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Mar 24, 2024
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Mar 24, 2024
This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8
MarijnS95
added a commit
to ash-rs/ash
that referenced
this pull request
Mar 24, 2024
* ash-window: Upgrade to raw-window-handle 0.6.0 This is the successor to #795. While it doesn't tackle things like backwards-compatibility nor use of the new lifetimed handles (if we _can_ even come up with a safe abstraction for them - it's very likely out of scope!), it includes the following improvements: - Upgrade `raw-window-metal` via [#8] (Mac/iOS wasn't tested in our CI); - Fix Windows platform types (in the `ash` crate) to be `isize` instead of `*const c_void`, matching the usptream definition; - Update example code (impossible until `winit` with `raw-window-handle 0.6` becomes available). [#8]: rust-windowing/raw-window-metal#8 * ash-window/examples/winit: Demonstrate proper surface lifetime with `Suspended`/`Resumed` events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no longer an
ns_windowmember in the new handles, so support for it had to be dropped. At the same time thens_viewmembers are appropriately markedNonNull<>so there's no longer a need for this fallback path.