Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cloud floating and submit button animation #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jayleenli
Copy link
Contributor

What's changed:

  • Added CSS cloud floating animations as described by Tina's design doc
  • Submit button enlarges on hover
  • NOTE: I didn't add the other mailing list animations since those probably will need JavaScript and I don't really wanna deal with that at the moment😌

@tshiUCSB feel free to edit the speed on the cloud animations

What's changed:
 - Added CSS cloud floating animations as described by Tina's design doc
 - Submit button enlarges on hover
 - NOTE: I didn't add the other mailing list animations since those probably will need javascript
@netlify
Copy link

netlify bot commented Oct 26, 2020

Deploy preview for sbhacksvii ready!

Built with commit 86ba164

https://deploy-preview-12--sbhacksvii.netlify.app

Copy link
Contributor

@btk5h btk5h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Animation timing needs a bit of tweaking, we should not be using a linear timing function since that looks unnatural (nothing in nature moves without acceleration/deceleration). The seal animation needs to move much faster as well.

In addition, the transition on the seal is creating an undesirable "slide-in" animation on page load.

Comment on lines +6 to +39
.float-logo-map-cloud {
animation: harmonic 8s infinite;
animation-timing-function: linear;
}
.float-cloud-back {
animation: harmonic 3s infinite;
animation-timing-function: linear;
}

.float-cloud-front {
animation: harmonic 6s infinite;
animation-timing-function: linear;
}

.w-wax_seal_submit_animation {
transition: transform 0.5s;
}

.w-wax_seal_submit_animation:hover {
transform: translateX(-50%) scale(1.2);
}

@keyframes harmonic {
0%,
100% {
transform: translateX(0);
}
25% {
transform: translateX(-1%);
}
75% {
transform: translateX(1%);
}
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general, we should not be writing custom CSS here. All new CSS should be registered with Tailwind, which auto-generates a lot of helpful utilities/modifiers and helps us keep a consistent design framework.

The documentation for doing that can be found here: https://tailwindcss.com/docs/animation#customizing, or I can convert the CSS over once the animation is tweaked.

Copy link
Contributor Author

@jayleenli jayleenli Oct 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My say is just merge it for now, since it works fine I just want our site to look slightly more lively cuz we are going to announce it tomorrow. It kinda looks dead - Feel free to change it to something better when you make application site. I showed to some of my friends and they really liked how there is animation on it

After seeing the difference between linear movement and sine wave movement, the linear one looks a lot better IMO. Tina is the judge on that though. I made a codepen comparing the difference- you can easily swap the keyframe animation for the sine wave one.

https://codepen.io/jayleenli/pen/ExyWNeq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants