-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cloud floating and submit button animation #12
Open
jayleenli
wants to merge
1
commit into
master
Choose a base branch
from
CSS-cloud-and-submit-button
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
<section class="relative inline-block text-3xl md:text-4xl lg:text-5xl md:mr-10 lg:mr-64 pointer-events-none"> | ||
<img src="/images/logo_map_cloud.png" alt class="invisible w-logo_map_cloud"> | ||
<img src="/images/logo_map_cloud_shade.png" alt class="absolute top-0 w-logo_map_cloud blend-multiply z-30"> | ||
<img src="/images/logo_map_cloud.png" alt class="absolute top-0 w-logo_map_cloud z-40"> | ||
<img src="/images/logo_map_cloud.png" alt class="invisible w-logo_map_cloud float-logo-map-cloud"> | ||
<img src="/images/logo_map_cloud_shade.png" alt class="absolute top-0 w-logo_map_cloud blend-multiply z-30 float-logo-map-cloud"> | ||
<img src="/images/logo_map_cloud.png" alt class="absolute top-0 w-logo_map_cloud z-40 float-logo-map-cloud"> | ||
<img src="/images/island.png" alt class="absolute top-9/12 left-1/6 w-island"> | ||
<img src="/images/cloud_back_shade.png" alt class="absolute bottom-1/6 left-7/12 z-20 blend-multiply w-cloud_back"> | ||
<img src="/images/cloud_back.png" alt class="absolute bottom-1/6 left-7/12 z-30 w-cloud_back"> | ||
<img src="/images/cloud_front_shade.png" alt class="absolute bottom-7/12 left-1/3 z-20 blend-multiply w-cloud_front"> | ||
<img src="/images/cloud_front.png" alt class="absolute bottom-7/12 left-1/3 z-30 w-cloud_front"> | ||
<div class="absolute top-1/2 w-full text-center text-brown-900 z-40 text-sm md:text-base lg:text-xl pointer-events-auto md:tracking-wide">{{ event_info.date_location }}</div> | ||
<img src="/images/cloud_back_shade.png" alt class="absolute bottom-1/6 left-7/12 z-20 blend-multiply w-cloud_back float-cloud-back"> | ||
<img src="/images/cloud_back.png" alt class="absolute bottom-1/6 left-7/12 z-30 w-cloud_back float-cloud-back"> | ||
<img src="/images/cloud_front_shade.png" alt class="absolute bottom-7/12 left-1/3 z-20 blend-multiply w-cloud_front float-cloud-front"> | ||
<img src="/images/cloud_front.png" alt class="absolute bottom-7/12 left-1/3 z-30 w-cloud_front float-cloud-front"> | ||
<div class="absolute top-1/2 w-full text-center text-brown-900 z-40 text-sm md:text-base lg:text-xl pointer-events-auto md:tracking-wide float-logo-map-cloud">{{ event_info.date_location }}</div> | ||
</section> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, we should not be writing custom CSS here. All new CSS should be registered with Tailwind, which auto-generates a lot of helpful utilities/modifiers and helps us keep a consistent design framework.
The documentation for doing that can be found here: https://tailwindcss.com/docs/animation#customizing, or I can convert the CSS over once the animation is tweaked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My say is just merge it for now, since it works fine I just want our site to look slightly more lively cuz we are going to announce it tomorrow. It kinda looks dead - Feel free to change it to something better when you make application site. I showed to some of my friends and they really liked how there is animation on it
After seeing the difference between linear movement and sine wave movement, the linear one looks a lot better IMO. Tina is the judge on that though. I made a codepen comparing the difference- you can easily swap the keyframe animation for the sine wave one.
https://codepen.io/jayleenli/pen/ExyWNeq