Improve error message for conflicting definitions #23453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now includes the signature in the message also when emitted from the typer. Co-authored-by: Matthieu Bovel <[email protected]>
|
I did also sign the CLA after the creation of this PR; the check should be green when it runs the next time. |
Co-Authored-By: Jan <[email protected]>
This was referenced Jul 1, 2025
|
@Jannyboy11: the |
|
(PR to be rebased when merging) |
sjrd
approved these changes
Jul 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now includes the signature in the message also when emitted from the typer.
Note: other checkfiles still need fixing, but I didn't update them locally due to a bug which happens on Windows where checkfiles are written with double linefeed characters (
\n\n).@mbovel this is the PR related to #23402.