-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calculations.mdx #224
base: main
Are you sure you want to change the base?
Conversation
daniel-earle-scope3
commented
Aug 15, 2024
- Updated based on (https://www.notion.so/scope3/Update-docs-guides-3eb00757116348dfa83f46fc0b997299)
- Updated a typo and wording
- Updated based on (https://www.notion.so/scope3/Update-docs-guides-3eb00757116348dfa83f46fc0b997299) - Updated a typo and wording
| `audio_duration_seconds` | Audio duration (if applicable) | | ||
| `video_duration_seconds` | Video duration (if applicable) | | ||
| `video_player` | Video player used to render video (if applicable) | | ||
| `other_assets_bytes` | Metadata, text, html, etc | | ||
| `ad_platforms` | Ad serving, verification, and measurement ad platforms wrapping or embedded in the ad format | | ||
| `identifier` | The identifying information, including name, channel, and device type | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We call this adFormat
in the docs and throughout the Scope3 application for integrate reporting. Should we be consistent here as well?
This identifier also does not contain the channel or device type. What we expect the identifier to for clients to give us does not contain that information nor does this field contain that for querying the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making changes as noted here.
if adFormat
is the correct field for consistency, then let's use that
| `creative_ad_format` | Either a basic or vendor-provided ad format | | ||
| `identifier` | The identifying information, including name, channel, and device type | | ||
| `vendor` | The name of the serving vendor | | ||
| `ad_format` | Either a basic or vendor-provided ad format | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why we have both identifier
and ad_format
here?
The identifier would also just be an identifying information. I think including name, channel, and device type
might be confusing what the user is meant to provide