-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update calculations.mdx #224
Open
daniel-earle-scope3
wants to merge
1
commit into
scope3data:main
Choose a base branch
from
daniel-earle-scope3:patch-1
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -55,12 +55,14 @@ import ChannelMappingDefaults from "/snippets/defaults_channel_mapping.mdx"; | |
| ------------------------ | -------------------------------------------------------------------------------------------- | | ||
| `rendered_width_pixels` | Width of the creative when rendered. Leave blank for responsive (will assume screen width) | | ||
| `rendered_height_pixels` | Height of the creative when rendered. Leave blank for responsive (will assume screen height) | | ||
| `image_sizes` | Array of image dimensions (eg `["300x250", "70x70"]`) | | ||
| `image_sizes_pixels` | Array of image dimensions (eg `["300x250", "70x70"]`) | | ||
| `audio_duration_seconds` | Audio duration (if applicable) | | ||
| `video_duration_seconds` | Video duration (if applicable) | | ||
| `video_player` | Video player used to render video (if applicable) | | ||
| `other_assets_bytes` | Metadata, text, html, etc | | ||
| `ad_platforms` | Ad serving, verification, and measurement ad platforms wrapping or embedded in the ad format | | ||
| `identifier` | The identifying information, including name, channel, and device type | | ||
| `vendor` | The name of the serving vendor | | ||
|
||
#### Sample Ad Formats: | ||
|
||
|
@@ -145,7 +147,9 @@ Native product carousel | |
| `device_type` | See [device types](#device-types) | | ||
| `network_type` | See [network types](#network-types) | | ||
| `property` | See [property](#property) | | ||
| `creative_ad_format` | Either a basic or vendor-provided ad format | | ||
| `identifier` | The identifying information, including name, channel, and device type | | ||
| `vendor` | The name of the serving vendor | | ||
| `ad_format` | Either a basic or vendor-provided ad format | | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm not sure why we have both The identifier would also just be an identifying information. I think |
||
| `creative_ad_platforms` | Ad serving, verification, and measurement ad platforms wrapping or embedded in the creative | | ||
| `creative_total_image_data_transfer_bytes` | Total bytes for the data transfer for the image itself for all impressions, ideally measured by the CDN | | ||
| `creative_image_sizes` | Array of image sizes included in the creative | | ||
|
@@ -159,7 +163,7 @@ Native product carousel | |
| `creative_video_view_time_seconds` | Average time, in seconds, that a video is viewed | | ||
| `creative_video_view_rate` | Average percentage of a video that is viewed | | ||
| `creative_time_in_view_seconds` | Time that the creative was visible on the device | | ||
| `creative_is_3p_served` | Is the ad format served by a third party ad server | | ||
| `creative_is_3p_served` | Is the ad format served by a third-party ad server | | ||
|
||
## Defaults | ||
|
||
|
@@ -236,13 +240,13 @@ Providers should clearly and publicly document: | |
|
||
## Fallbacks | ||
|
||
We use all data we have available on every single request but in many situations we may lack some information, for this | ||
we have a series of fallbacks to be able to provide reasonable estimates in most situations. | ||
We use all the available data on every request, but in many situations, we may lack some information. | ||
For this, we have a series of fallbacks to be able to provide reasonable estimates in most situations. | ||
|
||
To determine network when it's not submitted we calculate costs associated to network type | ||
To determine network when it's not submitted, we calculate costs associated to network type | ||
as a weighted average of the fixed and mobile usage in the country (if available) or worldwide. | ||
|
||
We can also generally determine the channel from the property or when that is ambiguous but we have device information | ||
We can also generally determine the channel from the property or when that is ambiguous, but we have device information | ||
we fall back to a default channel by device. | ||
|
||
``` | ||
|
@@ -459,7 +463,7 @@ media_data_transfer_emissions_gco2_per_imp = | |
media_data_transfer_embodied_emissions_gco2_per_imp | ||
``` | ||
|
||
Determing the session seconds for a single impressions | ||
Determining the session seconds for a single impressions | ||
|
||
``` | ||
session_seconds_per_imp = | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We call this
adFormat
in the docs and throughout the Scope3 application for integrate reporting. Should we be consistent here as well?This identifier also does not contain the channel or device type. What we expect the identifier to for clients to give us does not contain that information nor does this field contain that for querying the API
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
making changes as noted here.
if
adFormat
is the correct field for consistency, then let's use that