Ignore @smithy group #93
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72636c
reviewed
Aug 14, 2023
| @@ -93,6 +93,7 @@ | |||
| "^@?seek", | |||
| "seek$", | |||
| "^@aws-sdk/", | |||
| "^@smithy/", | |||
There was a problem hiding this comment.
🤔 This rule is scoped to devDependencies; these exclusions represent the packages that you want to exclude from the consolidated deps: npm dev dependencies PR (i.e. because they are grouped/PRed separately). Is smithy a prod or dev dep in your example?
There was a problem hiding this comment.
Hmmm it's a prod dep. Doesn't completely bother me but I thought it would always be grouped.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@smithy is the same as @AWS-SDK so it should only be seen in the same group.
Does adding it to this bit stop it from being created individually?