Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore @smithy group #93

Closed
wants to merge 1 commit into from
Closed

Ignore @smithy group #93

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions default.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@
"^@?seek",
"seek$",
"^@aws-sdk/",
"^@smithy/",
Copy link
Member

@72636c 72636c Aug 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 This rule is scoped to devDependencies; these exclusions represent the packages that you want to exclude from the consolidated deps: npm dev dependencies PR (i.e. because they are grouped/PRed separately). Is smithy a prod or dev dep in your example?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm it's a prod dep. Doesn't completely bother me but I thought it would always be grouped.

https://github.com/SEEK-Jobs/hirer-products-api/blob/73c21b676d75b3856945dabab3dcb6340d207d2b/package.json#L55

"^@types/",
"^@vanilla-extract/",
"^serverless"
Expand Down