Migrate set thread status from database layer #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreasHuber
force-pushed
the
migrate-set-thread-status-from-database-layer
branch
from
df44ac7 to
b941ce9
Compare
hugotiburtino
previously requested changes
Apr 25, 2024
Closed
kulla
approved these changes
May 1, 2024
| thread: { setThreadStatus: { success: true } }, | ||
| }) | ||
| given('UuidQuery').for({ ...comment, id: 35163, status: 'done' }) |
There was a problem hiding this comment.
This is needed as long as #1441 is not merged => The reason is that in resolving threads the old uuid resolver is used which does not read from DB
Comment on lines
307
to
309
| await context.dataSources.model.serlo.getUuid._querySpec.removeCache({ | ||
| payloads: ids.map((id) => ({ id })), | ||
| }) |
There was a problem hiding this comment.
This is needed as long as #1441 is not merged.
…ntries instead of removeCacheEntry
AndreasHuber
dismissed
hugotiburtino’s stale review
Added a test after the comment. The test revealed four bugs, including three from #1351, that are now fixed.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.