Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(workspaces): e2e-test as workspace #3177

Closed
wants to merge 21 commits into from
Closed

Conversation

elbotho
Copy link
Member

@elbotho elbotho commented Dec 6, 2023

Copy link

vercel bot commented Dec 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
frontend ✅ Ready (Inspect) Visit Preview Dec 12, 2023 1:18pm

Copy link
Contributor

github-actions bot commented Dec 6, 2023

📦 Next.js Bundle Analysis for @serlo/frontend

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.47 KB (🟡 +1 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

Sixteen Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/___editor_preview 475.78 KB (-2 B) 579.25 KB
/auth/error 55.63 KB (-2 B) 159.1 KB
/auth/login 80.59 KB (-2 B) 184.06 KB
/auth/logout 73.85 KB (-2 B) 177.32 KB
/auth/oauth/login 80.59 KB (-2 B) 184.06 KB
/auth/oauth/logout 73.86 KB (-2 B) 177.33 KB
/auth/recovery 62.48 KB (-2 B) 165.94 KB
/auth/registration 63.42 KB (-2 B) 166.89 KB
/auth/settings 63.53 KB (-2 B) 167 KB
/auth/verification 62.83 KB (-2 B) 166.3 KB
/entity/create/[type]/[taxonomyId] 477.19 KB (-2 B) 580.66 KB
/entity/repository/add-revision/[...id] 476.41 KB (-2 B) 579.87 KB
/page/create 476.42 KB (-2 B) 579.89 KB
/taxonomy/term/create/[parent_id]/[id] 476.11 KB (-2 B) 579.58 KB
/taxonomy/term/update/[id] 476.02 KB (-2 B) 579.49 KB
/user/settings 474.76 KB (-2 B) 578.23 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@elbotho
Copy link
Member Author

elbotho commented Dec 6, 2023

@Entkenntnis do you know why playwright ran without yarn playwright install in the old GitHub Action?

@Entkenntnis
Copy link
Member

it just worked 🤷‍♀️ probably run automatically.

Anyways - I thought about not adding it as workspace, but simple into a folder like ./e2e-tests, reasons: downloading browsers is quite heavy and we don't need it for the frontend + there is no coupling with existing code at all, so I don't see advantages of using it as a yarn workspace (maybe prettier can be shared, but that's only nice to have)

Thoughts?

@elbotho
Copy link
Member Author

elbotho commented Dec 6, 2023

(on slack)

@elbotho

This comment was marked as outdated.

@elbotho elbotho marked this pull request as ready for review December 7, 2023 11:25
@elbotho elbotho changed the title import e2e-test to workspace refactor(workspaces): e2e-test as workspace Dec 8, 2023
@elbotho
Copy link
Member Author

elbotho commented Dec 8, 2023

@Entkenntnis I don't really get why the tests are failing here. Any idea?

@Entkenntnis
Copy link
Member

maybe login is not possible because it's not staging?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants