Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): support VECTOR packets in static parser #3379

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

wellwelwel
Copy link
Collaborator

The support for VECTOR packets (MySQL 9+) has not been included with the static text parser in #3365. This PR just fixes it.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.51%. Comparing base (977fc7c) to head (e1dcecd).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
lib/parsers/static_text_parser.js 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3379      +/-   ##
==========================================
- Coverage   88.70%   88.51%   -0.20%     
==========================================
  Files          85       85              
  Lines       13446    13448       +2     
  Branches     1531     1525       -6     
==========================================
- Hits        11927    11903      -24     
- Misses       1519     1545      +26     
Flag Coverage Δ
compression-0 ?
compression-1 88.51% <50.00%> (-0.20%) ⬇️
static-parser-0 86.08% <0.00%> (-0.20%) ⬇️
static-parser-1 86.90% <50.00%> (-0.20%) ⬇️
tls-0 87.92% <50.00%> (-0.20%) ⬇️
tls-1 88.28% <50.00%> (-0.20%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel changed the title fix(query): support vector packets in static parser fix(query): support VECTOR packets in static parser Feb 5, 2025
@wellwelwel wellwelwel marked this pull request as ready for review February 5, 2025 02:28
@wellwelwel wellwelwel merged commit 603c246 into sidorares:master Feb 5, 2025
116 checks passed
@wellwelwel wellwelwel deleted the vector branch February 5, 2025 02:29
@wellwelwel wellwelwel mentioned this pull request Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant