Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve workflows #3380

Merged
merged 8 commits into from
Feb 5, 2025
Merged

ci: improve workflows #3380

merged 8 commits into from
Feb 5, 2025

Conversation

wellwelwel
Copy link
Collaborator

@wellwelwel wellwelwel commented Feb 5, 2025

This PR reorganizes the tests in a way that allows reusing MySQL versions and variations.

Also, MySQL 9 will also run through the coverage workflow, preventing issues like in #3379 (and that's how I discovered the related issue).

Another point is that we only tested version 8.0.x, instead of every minor versions.

Now, we test:

  • mysql:5.7
  • mysql:8.0
  • mysql:8.1 (new)
  • mysql:8.2 (new)
  • mysql:8.3 (new)
  • mysql:8.4 (soon)
  • mysql:9.0
  • mysql:9.1 (new)
  • mysql:9.2 (previously as latest)

I've also reused it better to avoid repeated tests, reducing from 116 to 100 workflows in total.

Finally, I updated all Node.js 20.x to the latest LTS (22).

Related

Note

  • If there's a specific patch version worth adding, we can also add it to ci-mysql.yml when needed.
  • Some tests never finish in MySQL 8.4, I intend to investigate this further soon.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.77%. Comparing base (603c246) to head (da7aaf9).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3380      +/-   ##
==========================================
+ Coverage   88.69%   88.77%   +0.08%     
==========================================
  Files          85       85              
  Lines       13448    13448              
  Branches     1532     1535       +3     
==========================================
+ Hits        11928    11939      +11     
+ Misses       1520     1509      -11     
Flag Coverage Δ
compression-0 88.77% <ø> (+0.08%) ⬆️
compression-1 88.77% <ø> (+0.08%) ⬆️
static-parser-0 86.33% <ø> (+0.06%) ⬆️
static-parser-1 87.16% <ø> (+0.07%) ⬆️
tls-0 88.19% <ø> (+0.08%) ⬆️
tls-1 88.54% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wellwelwel wellwelwel marked this pull request as ready for review February 5, 2025 03:10
@wellwelwel wellwelwel merged commit 2a9c7fc into sidorares:master Feb 5, 2025
100 checks passed
@wellwelwel wellwelwel deleted the ci branch February 5, 2025 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant