Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve workflows #3380

Merged
merged 8 commits into from
Feb 5, 2025
Merged

ci: improve workflows #3380

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ca9628a
ci: improve workflows
wellwelwel Feb 4, 2025
1d6a270
debug: check different minor versions
wellwelwel Feb 4, 2025
d17340a
ci: use same MySQL version in "ci-linux"
wellwelwel Feb 4, 2025
faff7e7
debug: focus Node.js static parsers to coverage workflows
wellwelwel Feb 4, 2025
efdc13f
debug: focus all MySQL 9 versions in "mysql" workflow
wellwelwel Feb 4, 2025
9d8d537
chore: remove debug
wellwelwel Feb 4, 2025
601a452
Merge branch 'master' into ci
wellwelwel Feb 5, 2025
da7aaf9
ci: add MySQL 9.0 to coverage workflow
wellwelwel Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [20.x]
node-version: [22]
mysql-version: ["mysql:8.0.18"]
use-compression: [0]
use-tls: [0]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/canary.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
if: steps.check_commit.outputs.publish == 'true'
uses: actions/setup-node@v4
with:
node-version: '22.x'
node-version: 22
registry-url: 'https://registry.npmjs.org'

- name: Cache dependencies
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/ci-coverage.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [20.x]
mysql-version: ['mysql:5.7', 'mysql:8.0.33']
node-version: [22]
mysql-version: ['mysql:5.7', 'mysql:8.0', 'mysql:9.0']
use-compression: [0, 1]
use-tls: [0, 1]
static-parser: [0, 1]
Expand Down
17 changes: 8 additions & 9 deletions .github/workflows/ci-linux.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,19 +18,18 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x, 20.x, 22.x, 23.x]
mysql-version: ['mysql:8.0.33']
node-version: [18, 20, 22, 23]
mysql-version: ['mysql:8.3']
use-compression: [0, 1]
use-tls: [0, 1]
static-parser: [0, 1]
mysql_connection_url_key: ['']
# static-parser: [0, 1] # Already tested in "ci-coverage"
# TODO - add mariadb to the matrix. currently few tests are broken due to mariadb incompatibilities

env:
MYSQL_CONNECTION_URL: ${{ secrets[matrix.mysql_connection_url_key] }}
STATIC_PARSER: ${{ matrix.static-parser }}

name: Node.js ${{ matrix.node-version }} - DB ${{ matrix.mysql-version }}${{ matrix.mysql_connection_url_key }} - SSL=${{matrix.use-tls}} Compression=${{matrix.use-compression}} Static Parser=${{matrix.static-parser}}
name: Node.js ${{ matrix.node-version }} - DB ${{ matrix.mysql-version }}${{ matrix.mysql_connection_url_key }} - SSL=${{matrix.use-tls}} Compression=${{matrix.use-compression}}

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -68,7 +67,7 @@ jobs:
fail-fast: false
matrix:
bun-version: [latest, canary]
mysql-version: ['mysql:8.0.33']
mysql-version: ['mysql:8.3']
use-compression: [0, 1]
use-tls: [0, 1]
static-parser: [0, 1]
Expand Down Expand Up @@ -123,7 +122,7 @@ jobs:
fail-fast: false
matrix:
deno-version: [v1.x]
mysql-version: ['mysql:8.0.33']
mysql-version: ['mysql:8.3']
use-compression: [0, 1]
static-parser: [0, 1]
# TODO: investigate error when using SSL (1)
Expand Down Expand Up @@ -181,7 +180,7 @@ jobs:
fail-fast: false
matrix:
deno-version: [v2.x, canary]
mysql-version: ['mysql:8.0.33']
mysql-version: ['mysql:8.3']
use-compression: [0, 1]
static-parser: [0, 1]
# TODO: investigate error when using SSL (1)
Expand Down Expand Up @@ -209,7 +208,7 @@ jobs:
- name: Set up Node.js
uses: actions/setup-node@v4
with:
node-version: 20
node-version: 22
- name: Cache dependencies
uses: actions/cache@v4
with:
Expand Down
20 changes: 12 additions & 8 deletions .github/workflows/ci-mysql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,15 +17,18 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [20.x] # LTS
node-version: [22]
mysql-version:
[
'mysql:5.7',
'mysql:8.0.18',
'mysql:8.0.22',
'mysql:8.0.33',
'mysql:9.0.1',
'mysql:latest',
# 'mysql:5.7', # Already tested in "ci-coverage"
# 'mysql:8.0', # Already tested in "ci-coverage"
'mysql:8.1',
'mysql:8.2',
# 'mysql:8.3', # Already tested in "ci-linux"
# 'mysql:8.4', # TODO: Tests never end
# 'mysql:9.0', # Already tested in "ci-coverage"
'mysql:9.1',
'mysql:9.2',
]
use-compression: [0, 1]
use-tls: [0, 1]
Expand All @@ -36,6 +39,7 @@ jobs:
mysql-version: 'datagrip/mysql:5.1'
use-compression: 0
use-tls: 0

env:
MYSQL_CONNECTION_URL: ${{ secrets[matrix.mysql_connection_url_key] }}

Expand Down Expand Up @@ -68,4 +72,4 @@ jobs:
run: node tools/wait-up.js

- name: Run tests
run: FILTER=${{matrix.filter}} MYSQL_USE_TLS=${{ matrix.use-tls }} MYSQL_USE_COMPRESSION=${{ matrix.use-compression }} npm run test
run: FILTER=${{matrix.filter}} npm run test
2 changes: 1 addition & 1 deletion .github/workflows/ci-osx.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [20.x] # LTS
node-version: [22]
use-compression: [0, 1]
use-tls: [0, 1]

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-tsc-build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [20.x]
node-version: [22]

name: Node.js ${{ matrix.node-version }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-website.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
- name: Actions - Setup NodeJS
uses: actions/setup-node@v4
with:
node-version: '20.x'
node-version: 22

- name: Cache Dependencies
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-windows.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [20.x] # LTS
node-version: [22]
mysql-version: ['8.0']
use-compression: [0, 1]
use-tls: [0, 1]
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/gh-pages.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
- name: Actions - Setup NodeJS
uses: actions/setup-node@v4
with:
node-version: '18.x'
node-version: 22

- name: Cache Dependencies
uses: actions/cache@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ on:
workflow_dispatch:

env:
NODE_VERSION: 20.x
NODE_VERSION: 22

jobs:
lint-js:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
- uses: actions/setup-node@v4
if: ${{ steps.release.outputs.release_created }}
with:
node-version: '20.x'
node-version: 22
registry-url: 'https://registry.npmjs.org'

- name: Cache dependencies
Expand Down
Loading