Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply via notification [macOS] #298

Closed
Vilscon opened this issue Oct 3, 2017 · 8 comments · Fixed by #726
Closed

Reply via notification [macOS] #298

Vilscon opened this issue Oct 3, 2017 · 8 comments · Fixed by #726
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted

Comments

@Vilscon
Copy link

Vilscon commented Oct 3, 2017

Issuehunt badges

Other apps in general, but Goofy (as Caprine alternative) have the option to reply via a notification. I hereby request the same feature 👍

jonivr earned $80.00 by resolving this issue!

@sindresorhus
Copy link
Owner

👍 Would be useful. Pull request welcome if anyone wants this :)

Goofy is open source, so I guess one could look at the source to see how it's implemented: https://github.com/danielbuechele/goofy-core Don't copy-paste the code though.

@salmanulfarzy
Copy link
Contributor

salmanulfarzy commented Nov 21, 2017

Does Goofy still support inline replies in notifications ? Looks like they are using notifications from electron.

if (!isMessageFromSelf && !muted) {
  let notification = new Notification(name, { body: messageBody, icon: image, data: id, silent: true });
  notification.onclick = e => {
    document.querySelector(`[id="${e.target.data}"] ${ACTIVATE_CONVERSATION}`).click();
  };

Electron supports inline replies from v1.7.3 or we could make use of node-mac-notifer.

@Rezonansowy
Copy link

I'd like to provide some reference pics of sample implementations:

click-on-reply-in-message-notification-on-mac
image 2016-04-14 at 2 37 47 pm
reply-to-messags-mac-notification
send-message-reply-notification-mac

@sindresorhus
Copy link
Owner

We don't control the notifications, but we could monkey patch Notification in the renderer (browser) process and detect when new notifications are emitted, then send them to the main process, and use the Electron Notification API which supports "reply".

@tobychin
Copy link

I'd like to take a gander at this! This would be a great feature to have.

@IssueHuntBot
Copy link

@issuehuntfest has funded $80.00 to this issue. See it on IssueHunt

@IssueHuntBot
Copy link

@JoniVR has submitted a pull request. See it on IssueHunt

@IssueHuntBot
Copy link

@sindresorhus has rewarded $72.00 to @JoniVR. See it on IssueHunt

  • 💰 Total deposit: $80.00
  • 🎉 Repository reward(0%): $0.00
  • 🔧 Service fee(10%): $8.00

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement 🎁 Rewarded on Issuehunt This issue has been rewarded on Issuehunt help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants