Tdl 14962 implement tap tester tests #53

prijendev · 2021-09-24T09:54:21Z

Description of change

TDL-14962 Implement QA tests

Added below test cases
- Test Discovery mode
- Test Bookmark
- Test Start Date
- Test All Fields
- Test Automatic Fields
- Test Sync canary

Note :

Test pagination has been skipped as there is no concept of pagination in API call.
Code coverage report not added for this PR as there is no unittest case.

Currently some line of code has been commented to pass the circelci build. Once PR 45 merge, I will uncomment the code and pass the circleci build.

Manual QA steps

Risks

Rollback steps

revert this branch

…ents

dbshah1212 · 2021-09-29T11:21:18Z

tests/tap_tester/test_automatic_fields.py

+
+    def test_run(self):
+        """
+        Verify that for each stream you can get enough data


It should be:

Verify we can deselect all fields except when inclusion=automatic, which is handled by base.py methods Verify that only the automatic fields are sent to the target. Verify that all replicated records have unique primary key values.

dbshah1212 · 2021-09-29T11:22:34Z

tests/tap_tester/test_all_fields.py

+        • Verify no unexpected streams were replicated
+        • Verify that more than just the automatic fields are replicated for each stream. 
+        • verify all fields for each stream are replicated
+        • verify that the automatic fields are sent to the target


This one we are testing as part of aumatic_field so not required here.

yes, removed it.

dbshah1212 · 2021-09-29T11:29:45Z

tests/tap_tester/test_start_date.py

+                    # collect information specific to incremental streams from syncs 1 & 2
+                    expected_replication_key = next(
+                        iter(self.expected_replication_keys().get(stream, [])))
+                    replication_dates_1 = [row.get('data').get(expected_replication_key) for row in


Can we change formating to make it more readable?

Yes, changes the formatting.

dbshah1212 · 2021-10-04T10:15:21Z

sample_config.json

@@ -1,4 +0,0 @@
-{


Why we removed this file?

Added back.

karanpanchal-crest · 2021-10-07T18:28:56Z

.circleci/config.yml

@@ -11,7 +11,7 @@ jobs:
            python3 -mvenv /usr/local/share/virtualenvs/tap-pendo
            source /usr/local/share/virtualenvs/tap-pendo/bin/activate
            pip install -U pip setuptools
-            pip install .[dev]
+            pip install .[test]


@prijendev Does this indicate that we no more consider the modules added as part of the 'dev' list?

Yes, because earlier circleci was failing due to ipdb dependency listed under 'dev' list. So, as per suggestion given in link split down 'dev' list dependency into 'test' and 'dev' list.

karanpanchal-crest · 2021-10-20T15:13:09Z

tests/tap_tester/test_sync.py

@@ -1,150 +1,34 @@
-import unittest


@prijendev Can you please explain the reason behind removing this code?

We have followed standard tap-tester suit. So, all expected metadata and helper methods available in base.py file. Then we are using that methods in all test cases. That's why we removed redundant code from test_sync file.

* bug fix for full table stream record count * updated config.yml file * added comment Co-authored-by: harshpatel4_crest <[email protected]>

* big fix for start date of child streams * updated test name * updated the code to fix bug in visitor history * added dev and test env * updated config.yml file, resolved review comments Co-authored-by: harshpatel4_crest <[email protected]>

* added best practices * bug fix * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR Co-authored-by: harshpatel4_crest <[email protected]>

* added backoff for error and timout for requests * added dev and test env * run unittests in CCi * created a variable for timeout seconds * added comments and updated the code to use param from config for timeout * updated the code and added test cases * added comment, updated readme file * typecasted request timeout, updated unittest name * added code change for empty string timeout value from config * updated timeout code and added unittests * resolved pylint error * resolve unittest failure Co-authored-by: harshpatel4_crest <[email protected]>

* removed the endpoints dictionary * Removed an unwanted comment * added best practices * bug fix * TDL-14795: Removed unused imports * TDL-14795: Undo extra line changes * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR * removed unused variable method * added unittest case for the updated code * resolved pylint errors * resolved pylint errors * resolved pylint errors * Removed f-string * resolved comments * added code coverage * fixec cirlceci error * resolved merge conflict * resolved removed conflict Co-authored-by: namrata270998 <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: dbshah1212 <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>

* removed the endpoints dictionary * Removed an unwanted comment * added best practices * bug fix * TDL-14795: Removed unused imports * TDL-14795: Undo extra line changes * TDL-6877 added backogg for conn reset error * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR * TDL-6877 resolved the comments * resolved pylint errors * resolved pylint errors * Removed f-string * added code coverage in circleci * removed unwanted imports * fixed unittest error Co-authored-by: namrata270998 <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: dbshah1212 <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>

* updated incremental streams as full table * added a comment for code change * added dev and test env * run unittests in CCi * resolve test case failure * updated start date in test_sync * updated comment * added comment Co-authored-by: harshpatel4_crest <[email protected]>

* TDL-14950 removed the line that caused the bug and addd a unittest * added best practices * bug fix * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR * resolved the comment and updated the testcase * removed commented code * Removed f-string from added code * added code coverage in circleci * added code comments Co-authored-by: namrata270998 <[email protected]> Co-authored-by: harshpatel4_crest <[email protected]> Co-authored-by: savan-chovatiya <[email protected]>

* TDL-14964: Fixed noneType date parsing * Resolve pylint failure * Added nose in setup * Added code comments * Added code comments * Resolve pylint error * Resolved review comment and add coverage report in CircleCI * Added bookmark check in all unit tests * Revert some code as it is as covered in other PR Co-authored-by: savan-chovatiya <[email protected]>

* TDL-14945: Fixed iterator by making list * Updated comment message * TDL-14945: Updated setup file for resolve CircleCI build * Added code comments * Reolved review comment and add code coverage report in CircleCI Co-authored-by: savan-chovatiya <[email protected]>

…to TDL-14962-implement-tap-tester-tests

prijendev added 5 commits September 10, 2021 17:14

Added new tep-tester test cases

0cc64d2

Updated all_fields test case for track_events stream

305dfdc

updated dev and test dependency for circleci

eb4cb85

Updated start_date and added lookback_window assertion in bookmark test.

9285815

Updated all_fields and automatic_fields test cases as per review comm…

7978e80

…ents

prijendev requested review from dbshah1212 and karanpanchal-crest September 24, 2021 09:56

dbshah1212 reviewed Sep 29, 2021

View reviewed changes

prijendev added 2 commits September 30, 2021 14:15

Updated as per review comments

d08f2c0

revert back replicatio key change

45b22cb

prijendev requested a review from dbshah1212 September 30, 2021 08:49

dbshah1212 reviewed Oct 4, 2021

View reviewed changes

Added back config file

7db0b87

karanpanchal-crest reviewed Oct 7, 2021

View reviewed changes

dbshah1212 requested review from karanpanchal-crest and dbshah1212 October 13, 2021 07:09

dbshah1212 approved these changes Oct 13, 2021

View reviewed changes

prijendev and others added 3 commits October 13, 2021 15:18

Commented some part of code

939cfc3

Updated circleci config file

751b2ef

Removed f-string

8fa6bf9

karanpanchal-crest reviewed Oct 20, 2021

View reviewed changes

karanpanchal-crest approved these changes Oct 21, 2021

View reviewed changes

prijendev requested a review from KrisPersonal October 22, 2021 06:00

KrisPersonal approved these changes Oct 25, 2021

View reviewed changes

prijendev and others added 4 commits October 27, 2021 12:11

Tdl 15671 full table sync record count (#60)

5a547ef

* bug fix for full table stream record count * updated config.yml file * added comment Co-authored-by: harshpatel4_crest <[email protected]>

Best practices (#62)

fcd1a19

* added best practices * bug fix * added test and dev groups * undo unittest code added to run in cci * undo the bug changes in this PR Co-authored-by: harshpatel4_crest <[email protected]>

prijendev and others added 10 commits October 27, 2021 13:46

Merge remote-tracking branch 'origin/TDL-15987-all-non-pk-changes' in…

9dab3f1

…to TDL-14962-implement-tap-tester-tests

Changes updated

87a577d

updated base file and bookmark test

5ee8cb2

Updated bookmark test

5b04c0f

prijendev mentioned this pull request Oct 28, 2021

Tdl 15987 all non pk changes #72

Merged

dsprayberry closed this Mar 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tdl 14962 implement tap tester tests #53

Tdl 14962 implement tap tester tests #53

prijendev commented Sep 24, 2021 •

edited

Loading

dbshah1212 Sep 29, 2021

prijendev Sep 30, 2021

dbshah1212 Sep 29, 2021

prijendev Sep 30, 2021

dbshah1212 Sep 29, 2021

prijendev Sep 30, 2021

dbshah1212 Oct 4, 2021

prijendev Oct 11, 2021

karanpanchal-crest Oct 7, 2021

prijendev Oct 11, 2021 •

edited

Loading

karanpanchal-crest Oct 20, 2021

prijendev Oct 21, 2021

Tdl 14962 implement tap tester tests #53

Tdl 14962 implement tap tester tests #53

Conversation

prijendev commented Sep 24, 2021 • edited Loading

Description of change

Manual QA steps

Risks

Rollback steps

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prijendev Oct 11, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prijendev commented Sep 24, 2021 •

edited

Loading

prijendev Oct 11, 2021 •

edited

Loading