-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tdl 17934 poc on rulemap implementation #132
Open
prijendev
wants to merge
17
commits into
crest-master
Choose a base branch
from
TDL-17934-poc-on-rulemap-implementation
base: crest-master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
Created
RuleMap
class which contain following below method,fill_rule_map_object_by_catalog
apply_ruleset_on_schema
apply_ruleset_on_stream_name
apply_rules_to_original_field
apply_ruleset_on_api_response
Added extra method
add_child_into_metadata
to add nested fields into metadata.The catalog contains the
original-name
field in metadata which contains the actual name field and the breadcrumb contains the standard name of the field.During sync mode,
apply_ruleset_on_api_response
would be called which converts the original field value to standard name, and then the transform would be applied.Manual QA steps
Risks
Rollback steps