Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type prop to SimpleGrid #433

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Add type prop to SimpleGrid #433

wants to merge 4 commits into from

Conversation

namakshenas
Copy link
Contributor

Fixes #428 / Add type prop to SimpleGrid

@AnnMarieW
Copy link
Collaborator

AnnMarieW commented Dec 2, 2024 •
edited
Loading

Hi @namakshenas Can you please add a changelog entry and this example from the Mantine docs? https://mantine.dev/core/simple-grid/#container-queries

Also, were you still planning on adding the Grid container queries? https://mantine.dev/core/grid/#container-queries

@namakshenas
Copy link
Contributor Author

namakshenas commented Dec 2, 2024 •
edited
Loading

Hi @namakshenas Can you please add a changelog entry and this example from the Mantine docs? https://mantine.dev/core/simple-grid/#container-queries

Hi @AnnMarieW,
Done. Thank you.

Also, were you still planning on adding the Grid container queries? https://mantine.dev/core/grid/#container-queries

Yes, ASAP.

@AnnMarieW AnnMarieW mentioned this pull request Jan 6, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add missing props
2 participants
@namakshenas @AnnMarieW