Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add module_path to ContractArtifacts #1082

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Add module_path to ContractArtifacts #1082

merged 5 commits into from
Jan 24, 2024

Conversation

tomek0123456789
Copy link
Contributor

Closes #1048

mkaput
mkaput requested changes Jan 24, 2024
View reviewed changes
scarb/src/compiler/compilers/starknet_contract.rs Outdated Show resolved Hide resolved
scarb/tests/build_starknet_contract.rs Outdated Show resolved Hide resolved
mkaput
mkaput reviewed Jan 24, 2024
View reviewed changes
Copy link
Member

@mkaput mkaput left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shifting clones further would be more idiomatic Rust.

scarb/src/compiler/compilers/starknet_contract.rs Outdated Show resolved Hide resolved
scarb/src/compiler/compilers/starknet_contract.rs Outdated Show resolved Hide resolved
@tomek0123456789 tomek0123456789 added this pull request to the merge queue Jan 24, 2024
Merged via the queue into main with commit e7fc484 Jan 24, 2024
20 checks passed
@tomek0123456789 tomek0123456789 deleted the tomek/1048-contract-module-path branch January 24, 2024 10:01
@chenrui333 chenrui333 mentioned this pull request Jan 30, 2024
Merged
@Arcticae Arcticae mentioned this pull request Feb 2, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mkaput mkaput mkaput approved these changes

@szymmis szymmis Awaiting requested review from szymmis

@maciektr maciektr Awaiting requested review from maciektr

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add contract module path information to Starknet artefacts file
2 participants
@tomek0123456789 @mkaput