Skip to content

Media metadata extraction & Thumbnailer rework #8614

Media metadata extraction & Thumbnailer rework

Media metadata extraction & Thumbnailer rework #8614

Triggered via pull request April 22, 2024 17:47
Status Failure
Total duration 31m 5s
Artifacts 2

ci.yml

on: pull_request
Matrix: clippy
Fit to window
Zoom out
Zoom in

Annotations

1 error and 20 warnings
Cypress
The process '/usr/bin/env' failed with exit code 1
unused `std::result::Result` that must be used: core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used --> core/crates/sync/src/ingest.rs:118:7 | 118 | self.receive_crdt_operation(op).await; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 118 | let _ = self.receive_crdt_operation(op).await; | +++++++
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:372:21 | 372 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10 | 742 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:9:2 | 9 | clippy::nursery, | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L829
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:829:25 | 829 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L830
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:830:10 | 830 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/mod.rs#L377
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/mod.rs:377:40 | 377 | pub_id_by_ancestor_materialized_path: &mut HashMap<String, (file_path::pub_id::Type, u64)>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&HashMap<String, (file_path::pub_id::Type, u64)>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/mod.rs#L379
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/mod.rs:379:10 | 379 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L270
warning: use of deprecated function `accept_dir_for_its_children`: Use `[accept_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:270:5 | 270 | accept_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ | note: the lint level is defined here --> core/crates/indexer-rules/src/lib.rs:25:2 | 25 | deprecated | ^^^^^^^^^^
use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L275
warning: use of deprecated function `reject_dir_for_its_children`: Use `[reject_dir_for_its_children_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:275:5 | 275 | reject_dir_for_its_children(source, children) | ^^^^^^^^^^^^^^^^^^^^^^^^^^^
use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L338
warning: use of deprecated method `RulePerKind::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:338:21 | 338 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead: core/crates/indexer-rules/src/lib.rs#L372
warning: use of deprecated method `IndexerRule::apply`: Use `[apply_with_metadata]` instead --> core/crates/indexer-rules/src/lib.rs:372:21 | 372 | .map(|rule| rule.apply(source.as_ref())) | ^^^^^
unused `std::result::Result` that must be used: core/crates/sync/src/ingest.rs#L118
warning: unused `std::result::Result` that must be used --> core/crates/sync/src/ingest.rs:118:7 | 118 | self.receive_crdt_operation(op).await; | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | = note: this `Result` may be an `Err` variant, which should be handled = note: `#[warn(unused_must_use)]` on by default help: use `let _ = ...` to ignore the resulting value | 118 | let _ = self.receive_crdt_operation(op).await; | +++++++
in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let`: crates/ffmpeg/src/format_ctx.rs#L31
warning: in a `match` scrutinee, avoid complex blocks or closures with blocks; instead, move the block or closure higher and bind it with a `let` --> crates/ffmpeg/src/format_ctx.rs:31:52 | 31 | match unsafe { metadata.as_mut() }.map(|metadata| { | _______________________________________________________^ 32 | | let mut metadata = FFmpegDict::new(Some(metadata)); 33 | | let name = CString::new("name").map_or(None, |key| { 34 | | let name = metadata.get(&key); ... | 41 | | (metadata, name) 42 | | }) { | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blocks_in_conditions = note: `#[warn(clippy::blocks_in_conditions)]` on by default
use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead: crates/sd-indexer/src/ephemeral.rs#L115
warning: use of deprecated associated function `sd_core_indexer_rules::IndexerRule::apply_all`: Use `[IndexerRuler::apply_all]` instead --> crates/sd-indexer/src/ephemeral.rs:115:32 | 115 | let result = IndexerRule::apply_all(rules, &path).await.map_err(|err| { | ^^^^^^^^^ | = note: `#[warn(deprecated)]` on by default
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L742
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:742:10 | 742 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut note: the lint level is defined here --> core/crates/heavy-lifting/src/lib.rs:9:2 | 9 | clippy::nursery, | ^^^^^^^^^^^^^^^ = note: `#[warn(clippy::needless_pass_by_ref_mut)]` implied by `#[warn(clippy::nursery)]`
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L829
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:829:25 | 829 | maybe_to_keep_walking: &mut Option<Vec<ToWalkEntry>>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Option<Vec<ToWalkEntry>>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut
this argument is a mutable reference, but not used mutably: core/crates/heavy-lifting/src/indexer/tasks/walker.rs#L830
warning: this argument is a mutable reference, but not used mutably --> core/crates/heavy-lifting/src/indexer/tasks/walker.rs:830:10 | 830 | errors: &mut Vec<NonCriticalJobError>, | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing to: `&Vec<NonCriticalJobError>` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_pass_by_ref_mut

Artifacts

Produced during runtime
Name Size
cypress-screenshots Expired
1.56 MB
cypress-videos Expired
2.65 MB