Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[issue-827] fix mispelling of OPERATING-SYSTEM #828

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

loulou123546
Copy link

A fix for issue #827

SPDX 2.3 reference use the term "OPERATING-SYSTEM" instead of "OPERATING_SYSTEM" which is was is output by this library.

Documentation: https://spdx.github.io/spdx-spec/v2.3/package-information/#724-primary-package-purpose-field

@loulou123546 loulou123546 changed the title [issue-827] fix mispelling of of OPERATING-SYSTEM [issue-827] fix mispelling of OPERATING-SYSTEM Oct 1, 2024
@loulou123546
Copy link
Author

Hello, can someone do a review of it?

@armintaenzertng
Copy link
Collaborator

Hi @loulou123546, thanks for your contribution! This has always been ambiguous as the json schema did not match the specification you cite. However, by now, the json schema allows for both dashes and underscores, so we could indeed switch to the more spec-conform dashes.
There is also the referenceCategory which has the same problem (see here in our code). We should change that to use dashes there, too, so that we stay consistent, I think.
Do you want to take care of that, too?
I have to look into why the pipeline does not start for this PR...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants