Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat (dui3): shared files #2459

Merged

Conversation

oguzhankoral
Copy link
Member

@oguzhankoral oguzhankoral commented Jul 1, 2024

People still use files

"Requesting Write Access" from DUI3 still a product question that we should clarify, so far checked with Claire and Bilal, but need your idea on this. We can disable it easliy. LMK what do you think @didimitrie.

  • We have projectAccount in ProjectModelGroup and CardBase to have related account as fallback if it doesn't match with provided account id but match with server url.

  • We mark project group as read only if user doesn't have write access even if server matches. We prevent to click operation on Sender card with this info

    • Sender can't do send operation if account has stream:reviewer role on project.
    • Receiver can receive regardless if project is public.

    image

  • User can request write-access by clicking lock button and we listen userProjectsUpdatedSubscription to refetch data. Whenever owner of the project accept request, project become normal state that can send objects only if owner assigned as stream:collaborator or stream:owner

    Rhino_9cLIkkUDWj

  • Whenever user remove the collaborator from project, UI also catch it and mark project read-only again. This is good because it solves the common issue if some roles changed on the way.

    Rhino_QFQrbpIN5r

  • When the project is private, we show common apollo error
    image

PS: Most of the logic handled in UI but it also has alignment changes on sharp side -> specklesystems/speckle-sharp#3550

Copy link

netlify bot commented Jul 1, 2024

Deploy Preview for boisterous-douhua-e3cefb ready!

Name Link
🔨 Latest commit cdc42dc
🔍 Latest deploy log https://app.netlify.com/sites/boisterous-douhua-e3cefb/deploys/668d7eff4b06100008cb2c78
😎 Deploy Preview https://deploy-preview-2459--boisterous-douhua-e3cefb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oguzhankoral oguzhankoral changed the title Feat (dui3): Persistent model cards regardless accounts Feat (dui3): File shared models Jul 2, 2024
@oguzhankoral oguzhankoral changed the title Feat (dui3): File shared models Feat (dui3): File shared projects Jul 2, 2024
@oguzhankoral oguzhankoral changed the title Feat (dui3): File shared projects Feat (dui3): shared files Jul 2, 2024
@oguzhankoral oguzhankoral requested a review from didimitrie July 2, 2024 16:14
@didimitrie
Copy link
Member

Looks good. I'm inclined to piggy back on this PR with some extra little things:

  • in the send wizard's first step, disable all projects where role <= reviewer
  • possibly nuance on a per model card basis based on project role:
image

I'm a reviewer in this project, so this means:

  • i can receive things
  • i cannot load things

…of no write access projects from publish wizard
@didimitrie
Copy link
Member

didimitrie commented Jul 9, 2024

Preventing selecting projects where role = reviewer in send wizard:

image

Reworks the whole "can't send data here" paradigm to work only on sender cards:

image

Note: not entirely happy with code, could do with more cleanup, but at this stage: YOLO.

Copy link
Member Author

@oguzhankoral oguzhankoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's fine for now I believe. Merging it!

@oguzhankoral oguzhankoral merged commit f75647a into dui3 Jul 9, 2024
25 of 27 checks passed
@oguzhankoral oguzhankoral deleted the oguzhan/dui3/persistent-model-cards-regardless-accounts branch July 9, 2024 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants