-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat (dui3): shared files #2459
Merged
oguzhankoral
merged 10 commits into
dui3
from
oguzhan/dui3/persistent-model-cards-regardless-accounts
Jul 9, 2024
Merged
Feat (dui3): shared files #2459
oguzhankoral
merged 10 commits into
dui3
from
oguzhan/dui3/persistent-model-cards-regardless-accounts
Jul 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for boisterous-douhua-e3cefb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
oguzhankoral
changed the title
Feat (dui3): Persistent model cards regardless accounts
Feat (dui3): File shared models
Jul 2, 2024
oguzhankoral
changed the title
Feat (dui3): File shared models
Feat (dui3): File shared projects
Jul 2, 2024
oguzhankoral
changed the title
Feat (dui3): File shared projects
Feat (dui3): shared files
Jul 2, 2024
…of no write access projects from publish wizard
didimitrie
approved these changes
Jul 9, 2024
oguzhankoral
commented
Jul 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fine for now I believe. Merging it!
oguzhankoral
deleted the
oguzhan/dui3/persistent-model-cards-regardless-accounts
branch
July 9, 2024 20:46
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
People still use files
"Requesting Write Access" from DUI3 still a product question that we should clarify, so far checked with Claire and Bilal, but need your idea on this. We can disable it easliy. LMK what do you think @didimitrie.
We have
projectAccount
inProjectModelGroup
andCardBase
to have related account as fallback if it doesn't match with provided account id but match with server url.We mark project group as read only if user doesn't have write access even if server matches. We prevent to click operation on Sender card with this info
Sender
can't do send operation if account hasstream:reviewer
role on project.Receiver
can receive regardless if project is public.User can request write-access by clicking lock button and we listen
userProjectsUpdatedSubscription
to refetch data. Whenever owner of the project accept request, project become normal state that can send objects only if owner assigned asstream:collaborator
orstream:owner
Whenever user remove the collaborator from project, UI also catch it and mark project read-only again. This is good because it solves the common issue if some roles changed on the way.
When the project is private, we show common apollo error
PS: Most of the logic handled in UI but it also has alignment changes on sharp side -> specklesystems/speckle-sharp#3550