chore(node): bump from 18 to 22 #2671
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
|
📸 Preview service has generated an image. |
iainsproat
commented
Feb 5, 2025
| && curl -fsSL https://deb.nodesource.com/setup_18.x | bash - \ | ||
| && curl -fsSL https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini -o /usr/bin/tini \ | ||
| && chmod +x /usr/bin/tini \ | ||
| && curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \ |
There was a problem hiding this comment.
Ubuntu noble doesn't package Node version 22, so we have to install it via nodesource
iainsproat
commented
Feb 5, 2025
fabis94
previously approved these changes
Feb 18, 2025
|
📸 Preview service has generated an image. |
fabis94
approved these changes
Feb 18, 2025
|
📸 Preview service has generated an image. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation
Node 18 is EOL in early 2025, and Node 22 is new LTS.
https://linear.app/speckle/project/remain-on-a-javascript-runtime-environment-with-long-term-support-31b50d0fdd9b/overview
Changes:
To-do before merge:
Screenshots:
Validation of changes:
Checklist:
References