-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(node): bump from 18 to 22 #2671
Open
iainsproat
wants to merge
12
commits into
main
Choose a base branch
from
iain/dockerfile-node18-node22
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+32
−27
Open
Changes from 9 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
cd3ef0e
chore(node): bump from 18 to 22
iainsproat 44a18a4
Revert accidentally committed change
iainsproat 2991984
fix nix package name
iainsproat efbdd16
small fixes to the docker file
iainsproat a4bff8d
Merge branch 'main' into iain/dockerfile-node18-node22
iainsproat dcdceda
Merge branch 'main' into iain/dockerfile-node18-node22
iainsproat 0d430f8
Bump nix package
iainsproat d33b6ff
Merge branch 'main' into iain/dockerfile-node18-node22
iainsproat aaaf75d
Merge branch 'main' into iain/dockerfile-node18-node22
iainsproat 3c63232
Merge branch 'main' into iain/dockerfile-node18-node22
iainsproat 220b9bb
fix tailwind-theme engine version
iainsproat db7baac
Merge branch 'main' into iain/dockerfile-node18-node22
iainsproat File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -15,17 +15,22 @@ WORKDIR /speckle-server | |
ARG TINI_VERSION=v0.19.0 | ||
ENV TINI_VERSION=${TINI_VERSION} | ||
|
||
# hadolint ignore=DL3008 | ||
RUN apt-get update -y \ | ||
&& DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
--no-install-recommends \ | ||
ca-certificates=20240203 \ | ||
curl=8.5.0-2ubuntu10.6 \ | ||
gosu=1.17-1ubuntu0.24.04.2 \ | ||
&& curl -fsSL https://deb.nodesource.com/setup_18.x | bash - \ | ||
&& curl -fsSL https://github.com/krallin/tini/releases/download/${TINI_VERSION}/tini -o /usr/bin/tini \ | ||
&& chmod +x /usr/bin/tini \ | ||
&& curl -fsSL https://deb.nodesource.com/setup_22.x -o nodesource_setup.sh \ | ||
&& gosu root:root bash nodesource_setup.sh \ | ||
&& DEBIAN_FRONTEND=noninteractive apt-get install -y \ | ||
--no-install-recommends \ | ||
nodejs=18.20.5-1nodesource1 \ | ||
nodejs \ | ||
&& echo ">>>>>> NODE Version: $(node --version)" \ | ||
&& npm install -g [email protected] \ | ||
&& corepack enable \ | ||
&& DEBIAN_FRONTEND=noninteractive apt-get remove curl -y \ | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,7 +12,7 @@ | |
"url": "git+https://github.com/specklesystems/speckle-server.git" | ||
}, | ||
"engines": { | ||
"node": "^18.19.0" | ||
"node": "^22.6.0" | ||
}, | ||
"scripts": { | ||
"dev": "cross-env POSTGRES_URL=postgres://speckle:[email protected]/speckle NODE_ENV=development LOG_PRETTY=true SPECKLE_SERVER_URL=http://127.0.0.1:3000 nodemon --no-experimental-fetch ./src/daemon.js", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ubuntu
noble
doesn't package Node version 22, so we have to install it via nodesource