Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tiny Stream Camera Navigation Fix #3930

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Tiny Stream Camera Navigation Fix #3930

merged 2 commits into from
Feb 4, 2025

Conversation

AlexandruPopovici
Copy link
Contributor

Description & motivation

Handles https://linear.app/speckle/issue/WEB-2593/tiny-stream-being-weird:

  • The orbit controller would not properly report changes in camera movement on a per frame basis becuase of a hardcoded epsilon which was not small enough for very small scenes. Now the epsilon is dynamically computed
  • WASD-ing would jitter in very small scenes because of a too large normalization value sent to the position dampers. Now that value is also dynamically computed for small scenes

Changes:

To-do before merge:

Screenshots:

Validation of changes:

Checklist:

  • My pull request follows the guidelines in the Contributing guide?
  • My pull request does not duplicate any other open Pull Requests for the same update/change?
  • My commits are related to the pull request and do not amend unrelated code or documentation.
  • My code follows a similar style to existing code.
  • I have added appropriate tests.
  • I have updated or added relevant documentation.

References

- The orbit controller would not properly report changes in camera movement on a per frame basis becuase of a hardcoded epsilon which was not small enough for very small scenes. Now the epsilon is dynamically computed
- WASD-ing would jitter in very small scenes because of a too large normalization value sent to the position dampers. Now that value is also dynamically computed for small scenes
Copy link

linear bot commented Feb 4, 2025

Copy link
Contributor

github-actions bot commented Feb 4, 2025

📸 Preview service has generated an image.

@AlexandruPopovici AlexandruPopovici merged commit 065c242 into main Feb 4, 2025
28 of 30 checks passed
@AlexandruPopovici AlexandruPopovici deleted the alex/WEB-2593 branch February 4, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants