Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NameAndRankValue now uses a type to get FullName to avoid conflicts #475

Merged
merged 4 commits into from
Jan 10, 2025

Conversation

adamhathcock
Copy link
Member

@adamhathcock adamhathcock commented Jan 8, 2025

Loading Autocad 2025 with Civil3d plugin (quesitonable) using a model with a TinSurface resulted in resolving to an Autocad specific converter (ADB.Surface) instead of a converter using the Civil3d Surface or Entity.

Fully namespaced types are needed to resolve the correct converter

related: https://github.com/specklesystems/speckle-sharp-sdk/pull/476

Copy link

codecov bot commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes missing coverage. Please review.

Project coverage is 9.17%. Comparing base (c5d37a1) to head (eac9f9e).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...verters.Common/Registration/ServiceRegistration.cs 0.00% 9 Missing ⚠️
...kle.Converters.Common/NameAndRankValueAttribute.cs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##             dev    #475   +/-   ##
=====================================
  Coverage   9.17%   9.17%           
=====================================
  Files        228     228           
  Lines       4296    4295    -1     
  Branches     542     542           
=====================================
  Hits         394     394           
+ Misses      3886    3885    -1     
  Partials      16      16           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamhathcock adamhathcock enabled auto-merge (squash) January 9, 2025 08:43
@adamhathcock adamhathcock merged commit 94104c2 into dev Jan 10, 2025
3 checks passed
@adamhathcock adamhathcock deleted the adam/cnx-990-unable-to-cast-object-of-type branch January 10, 2025 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants