Implement equals and hashCode in OidcIdToken
#17485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes: spring-projects#15156 Signed-off-by: Andrey Litvitski <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
| @@ -73,6 +73,23 @@ public Map<String, Object> getClaims() { | |||
| return this.claims; | |||
| } | |||
|
|
|||
| @Override | |||
| public boolean equals(Object obj) { | |||
| if (this == obj) { | |||
There was a problem hiding this comment.
I think pattern matching can be applied here
if (obj instanceof OidcIdToken that) {
return this.claims.equals(that.claims);
}
return false;
There was a problem hiding this comment.
I don't think there's any point in that. You can implement the method in different ways, but make it perform the same task. I copied and polished these methods from a neighboring class, so I don't think anything needs to be changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #15156