Skip to content

Implement equals and hashCode in OidcIdToken #17485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement equals and hashCode in OidcIdToken #17485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions .../oauth2-core/src/main/java/org/springframework/security/oauth2/core/oidc/OidcIdToken.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,23 @@ public Map<String, Object> getClaims() {
return this.claims;
}

@Override
public boolean equals(Object obj) {
if (this == obj) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think pattern matching can be applied here

if (obj instanceof OidcIdToken that) {
	return this.claims.equals(that.claims);
}

return false;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's any point in that. You can implement the method in different ways, but make it perform the same task. I copied and polished these methods from a neighboring class, so I don't think anything needs to be changed.

return true;
}
if (obj == null || this.getClass() != obj.getClass()) {
return false;
}
OidcIdToken that = (OidcIdToken) obj;
return this.getClaims().equals(that.getClaims());
}

@Override
public int hashCode() {
return this.getClaims().hashCode();
}

/**
* Create a {@link Builder} based on the given token value
* @param tokenValue the token value to use
Expand Down