Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the addition of
debuggingName
(here), we weren't effectively using that for Workers because we were still directly overridingtoString()
in the forwarding action forsendAndAwaitApplication
- we need to have that usedebuggingName
of the originalEmitWorkerOutputAction
in order to effectively get the debugging names through.The other change here is just to make
EmitWorkerOutputAction
debuggingName
a constant with the interpolation for worker and key rather than trying to fetch teh class name (we already know the class name!).Lastly, this doesn't fix #391 as the root problem there is that the
action
we care about in terms of what we created in the handler we passed torunningWorker
is a cascade action that isn't the one pulled off the queue (that'sEmitWorkerOutputAction
) but only is applied as the 2nd part of the cascade. There is no good solution there as the action is actually created after the worker's output is handled and starts a cascade. In other words, to provide that insight, we have to do that in the interceptors that instrument action cascades.