Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pipe Worker Output Action Names #1241

Merged
merged 1 commit into from
Dec 13, 2024

Conversation

steve-the-edwards
Copy link
Contributor

@steve-the-edwards steve-the-edwards commented Dec 13, 2024

After the addition of debuggingName (here), we weren't effectively using that for Workers because we were still directly overriding toString() in the forwarding action for sendAndAwaitApplication - we need to have that use debuggingName of the original EmitWorkerOutputAction in order to effectively get the debugging names through.

The other change here is just to make EmitWorkerOutputAction debuggingName a constant with the interpolation for worker and key rather than trying to fetch teh class name (we already know the class name!).

Lastly, this doesn't fix #391 as the root problem there is that the action we care about in terms of what we created in the handler we passed to runningWorker is a cascade action that isn't the one pulled off the queue (that's EmitWorkerOutputAction) but only is applied as the 2nd part of the cascade. There is no good solution there as the action is actually created after the worker's output is handled and starts a cascade. In other words, to provide that insight, we have to do that in the interceptors that instrument action cascades.

@steve-the-edwards steve-the-edwards force-pushed the sedwards/worker-action-naming branch from f6ee63f to aff9c4f Compare December 13, 2024 19:02
@steve-the-edwards steve-the-edwards merged commit 7a0d51d into main Dec 13, 2024
30 checks passed
@steve-the-edwards steve-the-edwards deleted the sedwards/worker-action-naming branch December 13, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

I think we broke the name param to action() when fired from workers
2 participants