feat(workspace_tests): test that only publishable member crates have versions #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Jan 24, 2025
dorimedini-starkware
requested review from
giladchase and
Itay-Tsabary-Starkware
giladchase
approved these changes
Jan 26, 2025
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_to_enforce_no_self-dependencies
branch
from
68106d3 to
d5076cb
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_that_only_publishable_member_crates_have_versions
branch
from
71692dc to
a7c33d0
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_to_enforce_no_self-dependencies
branch
from
d5076cb to
f1ad426
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_that_only_publishable_member_crates_have_versions
branch
from
a7c33d0 to
659e412
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_to_enforce_no_self-dependencies
branch
from
f1ad426 to
39771ba
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_that_only_publishable_member_crates_have_versions
branch
from
659e412 to
2180d1b
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_to_enforce_no_self-dependencies
branch
from
39771ba to
4f2d5f3
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_that_only_publishable_member_crates_have_versions
branch
from
2180d1b to
da7f905
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_to_enforce_no_self-dependencies
branch
from
4f2d5f3 to
d42555c
Compare
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_that_only_publishable_member_crates_have_versions
branch
from
da7f905 to
c9f04c5
Compare
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2, all commit messages.
Reviewable status:
dorimedini-starkware
force-pushed
the
01-24-feat_workspace_tests_test_that_only_publishable_member_crates_have_versions
branch
from
c9f04c5 to
f9a0e6c
Compare
dorimedini-starkware
changed the base branch from
01-24-feat_workspace_tests_test_to_enforce_no_self-dependencies
to
main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.