feat(workspace_tests): drop path requirement for dev dependencies

[dorimedini-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[dorimedini-starkware]

• feat(workspace_tests): drop path requirement for dev dependencies #3653 👈 (View in Graphite)
• feat(workspace_tests): test that only publishable member crates have versions #3652
• feat(workspace_tests): test to enforce no self-dependencies #3651
• fix(workspace_tests): remove direct self-dependencies #3650
• feat(workspace_tests): load member tomls only once #3649
• chore(workspace_tests): combine impl blocks of CrateCargoToml #3648
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[github-actions]

Artifacts upload workflows:

• Started at 2025-01-24T17:55:52Z
• Started at 2025-01-26T10:47:07Z
• Started at 2025-01-26T11:13:35Z
• Started at 2025-01-26T11:58:09Z
• Started at 2025-02-12T10:28:38Z
• Started at 2025-02-12T10:51:24Z
• Started at 2025-02-12T11:07:30Z
• Started at 2025-02-12T14:06:37Z
• Started at 2025-02-12T14:39:46Z
• Started at 2025-02-13T12:58:31Z

[giladchase]

Reviewed 32 of 32 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Itay-Tsabary-Starkware)

[dorimedini-starkware]

Reviewed 11 of 19 files at r2.
Reviewable status: 21 of 36 files reviewed, all discussions resolved (waiting on @giladchase and @Itay-Tsabary-Starkware)

---

workspace_tests/toml_utils.rs line 68 at r3 (raw file):

    pub(crate) fn path_dependencies(&self) -> impl Iterator<Item = String> + '_ {
        self.dependencies.iter().flatten().chain(self.dev_dependencies.iter().flatten()).filter_map(

the path_dependencies function is used by the validate_no_path_dependencies test. now, even dev-dependencies should use workspace=true instead of path="../X".

Code quote:

chain(self.dev_dependencies.iter().flatten())

[dorimedini-starkware]

Reviewable status: 21 of 36 files reviewed, all discussions resolved (waiting on @giladchase and @Itay-Tsabary-Starkware)

---

workspace_tests/package_integrity_test.rs line 126 at r3 (raw file):

///   dependency, we will not be able to publish starknet_api.
#[test]
fn test_member_dev_dependencies_are_by_path() {

no longer required.
non-publishable crates don't have a version (this is enforced by test_members_have_version_iff_they_are_for_publish),
and we enforce no circular crate dependencies (including self-deps) can exist in test_no_self_dependencies.

So, we don't need path deps anymore (and we don't want them)

Code quote:

/// For smooth publishing: all *local* (workspace member) dependencies in [dev-dependencies] should
/// be via path, and not `workspace = true`.
/// Reason:
/// - `cargo publish` ignores path dependencies in dev-dependencies.
/// - `cargo publish` DOES NOT ignore `workspace = true` dependencies in dev-dependencies, even if
///   the workspace toml defines the dependency via path.
/// - We do not need dev-dependencies published when publishing a crate.
/// - We sometimes use self-references in dev-dependencies to activate features of self in tests.
///   For example, starknet_api needs it's "testing" feature activated in test mode, so it has a
///   dependency on self (starknet_api) in dev-dependencies. If we fail to ignore this self
///   dependency, we will not be able to publish starknet_api.
#[test]
fn test_member_dev_dependencies_are_by_path() {